-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding onReady and onError callback for standalone footer #3732
base: stage
Are you sure you want to change the base?
Conversation
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
Hi @bandana147 , Please look into the console error that was seen when clicked on "Change Region." CC: @spadmasa |
Should be fixed now. |
b29d1c3
to
369e48e
Compare
|
||
if (configBlock) { | ||
const config = getConfig(); | ||
const gnavSource = `${config?.locale?.contentRoot}/gnav`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just for the standalone nav, right? We don't need to consider gnav-source
metadata, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes Narcis. Just for standalone gnav.
Resolves: MWPW-159105
Test URLs:
QA: https://adobecom.github.io/nav-consumer/?env=stage&authoringpath=/federal/home&navbranch=footer-callback