Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding onReady and onError callback for standalone footer #3732

Open
wants to merge 3 commits into
base: stage
Choose a base branch
from

Conversation

bandana147
Copy link
Contributor

  • Adding onError and onReady call specific to header and footer component
  • Since footer's init has a setTimeout, we cannot call the onError and onReady like header in the try/catch. It has to be called from the component itself.

Resolves: MWPW-159105

Test URLs:

QA: https://adobecom.github.io/nav-consumer/?env=stage&authoringpath=/federal/home&navbranch=footer-callback

Copy link
Contributor

aem-code-sync bot commented Feb 25, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Feb 25, 2025

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@spadmasa spadmasa self-assigned this Feb 25, 2025
Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@prativas22
Copy link

Hi @bandana147 , Please look into the console error that was seen when clicked on "Change Region."
https://adobecom.github.io/nav-consumer/?env=stage&authoringpath=/federal/learn&navbranch=footer-callback#langnav
image

CC: @spadmasa

@bandana147
Copy link
Contributor Author

Hi @bandana147 , Please look into the console error that was seen when clicked on "Change Region." https://adobecom.github.io/nav-consumer/?env=stage&authoringpath=/federal/learn&navbranch=footer-callback#langnav image

CC: @spadmasa

Should be fixed now.

@aem-code-sync aem-code-sync bot temporarily deployed to footer-callback March 6, 2025 09:03 Inactive

if (configBlock) {
const config = getConfig();
const gnavSource = `${config?.locale?.contentRoot}/gnav`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just for the standalone nav, right? We don't need to consider gnav-source metadata, correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes Narcis. Just for standalone gnav.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants