MWPW-167748 Fix focus in georouting modal with tabs

[meganthecoder]

• Fix focus in georouting modal with tabs

Resolves: MWPW-167748

Test URLs:

• Before: https://main--milo--adobecom.aem.page/?martech=off
• After: https://geo-focus--milo--meganthecoder.aem.page/?martech=off

Bacom:

• https://main--bacom--adobecom.aem.live/?milolibs=geo-focus--milo--meganthecoder&akamaiLocale=IN

[aem-code-sync]

	Page	Scores	Audits	Google
📱	/?martech=off
🖥️	/?martech=off

[vhargrave]

@meganthecoder I can't even reproduce the original issue. When I open the georouting and press tab it immediately starts tabbing within the modal. Am I just blindly missing something?

[DKos95]

@meganthecoder I can't even reproduce the original issue. When I open the georouting and press tab it immediately starts tabbing within the modal. Am I just blindly missing something?

I think I had the same issue to notice it because I was clicking on the url in the task and it is missing the locale param(?akamaiLocale=IN) then when tabbing it goes to the languages, but if you have a local param it goes to the logo when tabbing and then when you add milolibs=geo-focus--milo--meganthecoder along with the locale param it seems fixed to me.

• https://main--bacom--adobecom.aem.live/?akamaiLocale=IN
• https://main--bacom--adobecom.aem.live/?milolibs=geo-focus--milo--meganthecoder&akamaiLocale=IN

[github-actions]

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

[spadmasa]

Hi @meganthecoder , As part of this ticket we have https://jira.corp.adobe.com/browse/MWPW-168432 was checking on the fix, I am on India Connected to Bangalore VPN, able to get geo popup by default.When tested with this url still see the issue. Can you please advise
https://main--cc--adobecom.hlx.live/creativecloud?milolibs=geo-focus--milo--meganthecoder

[vhargrave]

Hi @meganthecoder , As part of this ticket we have https://jira.corp.adobe.com/browse/MWPW-168432 was checking on the fix, I am on India Connected to Bangalore VPN, able to get geo popup by default.When tested with this url still see the issue. Can you please advise https://main--cc--adobecom.hlx.live/creativecloud?milolibs=geo-focus--milo--meganthecoder

I have the same issue as well
@meganthecoder i took a brief look and what's interesting is that the CC modal is appearing into view after the focus is set, whereas for bacom it's appearing before. Since focus isn't set for elements that are not visible, I think that might be part of the issue for CC. Bacom works fine.

[meganthecoder]

@vhargrave @spadmasa Please have another look. I've excluded the paddle now, which seems like the simplest solution. It looks like in some cases it was picking up the paddle before the disabled attribute was added.

[github-actions]

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.