New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] Stage to Main #3764

Merged

milo-pr-merge merged 9 commits into main from stage

Mar 4, 2025

Contributor

milo-pr-merge bot commented Mar 3, 2025

common base root URLs

Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html

Milo:

narcis-radu and others added 9 commits

March 3, 2025 10:27


          [MWPW-159511] Create anchor (ID) elements (#3714)

2cf0d52

* [MWPW-159511] Create anchor (ID) elements

* address feedback

* address feedback


          [MWPW-167031] top tooltip rtl fix (#3618)

8d7557a

* [MWPW-167031] tooltip top rtl fix

* [MWPW-167031] spacing corrections

* [MWPW-167031] css optimization

* [MWPW-167031] replaced css with js logic

* [MWPW-167031] optimization

* [MWPW-167031] optimization


          MWPW-164492: Plans Card via MAS (#3649)

d6aa49d

* first draft

* add callout

* fix stock js issue

* fix plans variant

* remove sitemap

* fix unit tests

* add nala tests

* MWPW-167305 [Plans Milo] Callout grey block: authoring improvement (#3663)

Co-authored-by: Bozo Jovicic <[email protected]>

* use consonant cta for plans

* add plans.md

* fix review comments

* fix merge issue

* revert obsolete change

* fix nala tests

* address review comments

* merge in stage

* Fix regression

* fix nala tests comments

---------

Co-authored-by: Bozo Jovicic <[email protected]>
Co-authored-by: Bozo Jovicic <[email protected]>


          MWPW-160954 Marketo Multi-step (#3671)

b19c749

* MWPW-160954 Marketo Multi-step

* PR Changes

* QA Fixes

* Next button fix


          Adding support for first localnav menu being a dropdown (#3693)

630af18

* Adding support for localnav item being a dropdown

* Fix for button text

* wip

* Updating title for dropdown

* Updating mock for localnav

* Fixing button text

* Lint fix

* Replacing button text after copying

* Lint fix


          [MWPW-162639] youtube block a tag fix (#3703)

a8d0552

* [MWPW-162639] youtube block a tag fix

* [MWPW-162639] condition update

* [MWPW-162639] clause fix

* [MWPW-162639] code removal


          Fix(mwpw-163031): Typo fix long-form (#3710)

3bbbff0

* new event added for autoplay videos

* combining the fixe for 163031

* Update adobetv.js


          Upgrading standalone gnav version to 0.0.5 (#3712)

161e06b

Upgrading gnav version to 0.0.5


          MWPW-167455: Remove node cloning (#3715)

794c0b0

* MWPW-167455: Remove node cloning

* MWPW-167455: Remove redundant code

* MWPW-167455: Remove video test

* MWPW-167455: Remove unnecessary code

* MWPW-167455: Change test name

Contributor Author

milo-pr-merge bot commented Mar 3, 2025

Testing can start @adobecom/bacom-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot @adobecom/express-sot @adobecom/homepage-sot @adobecom/miq-sot

milo-pr-merge bot requested review from Brandon32, meganthecoder, JasonHowellSlavin, salonijain3, bandana147, sharmrj, nishantka, Deva309 and sonawanesnehal3 as code owners

March 3, 2025 10:28

Contributor

aem-code-sync bot commented Mar 3, 2025 •

edited

Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

Re-run PSI checks
Re-sync branch

Commits

794c0b0 ✅ (latest)
161e06b ✅
3bbbff0 ✅
a8d0552 ✅
630af18 ✅
b19c749 ✅
d6aa49d ✅
8d7557a ✅
2cf0d52 ✅

Contributor

aem-code-sync bot commented Mar 3, 2025

	Page	Scores	Audits	Google
📱	/?martech=off
🖥️	/?martech=off

github-actions bot reviewed

View reviewed changes

Contributor

github-actions bot left a comment

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/794c0b0920e59348e1a2fe3a05bdffa65f91fb25/libs/features/mas/test/hydrate.test.js

github-actions bot reviewed

View reviewed changes

libs/deps/mas/mas.js

Contributor

github-actions bot Mar 3, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions bot reviewed

View reviewed changes

libs/deps/mas/merch-card.js

Contributor

github-actions bot Mar 3, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions bot reviewed

View reviewed changes

libs/features/mas/dist/mas.js

Contributor

github-actions bot Mar 3, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions bot reviewed

View reviewed changes

libs/features/mas/src/aem-fragment.js

Contributor

github-actions bot Mar 3, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions bot reviewed

View reviewed changes

libs/features/mas/src/global.css.js

Contributor

github-actions bot Mar 3, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions bot reviewed

View reviewed changes

libs/features/mas/src/hydrate.js

Contributor

github-actions bot Mar 3, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions bot reviewed

View reviewed changes

libs/features/mas/src/merch-card.js

Contributor

github-actions bot Mar 3, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions bot reviewed

View reviewed changes

libs/features/mas/src/variants/plans.css.js

Contributor

github-actions bot Mar 3, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions bot reviewed

View reviewed changes

libs/features/mas/src/variants/plans.js

Contributor

github-actions bot Mar 3, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions bot reviewed

View reviewed changes

libs/features/mas/src/variants/variants.js

Contributor

github-actions bot Mar 3, 2025

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

mokimo temporarily deployed to milo_pr_merge

March 3, 2025 12:30

— with

GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge

March 3, 2025 16:18

— with

GitHub Actions Inactive

tedAir self-requested a review

March 3, 2025 18:40

fullcolorcoder added the Express SOT 👌 label

fullcolorcoder temporarily deployed to milo_pr_merge

March 3, 2025 19:47

— with

GitHub Actions Inactive

fullcolorcoder approved these changes

View reviewed changes

JackySun9 approved these changes

View reviewed changes

JackySun9 added the MIQ SOT👌 label

mokimo temporarily deployed to milo_pr_merge

March 3, 2025 20:16

— with

GitHub Actions Inactive

JackySun9 temporarily deployed to milo_pr_merge

March 3, 2025 20:16

— with

GitHub Actions Inactive

Dli3 approved these changes

View reviewed changes

Dli3 added the BAcom SOT 👌 label

Dli3 temporarily deployed to milo_pr_merge

March 3, 2025 23:20

— with

GitHub Actions Inactive

Roycethan approved these changes

View reviewed changes

Roycethan added the Homepage SOT 👌 label

Roycethan temporarily deployed to milo_pr_merge

March 3, 2025 23:46

— with

GitHub Actions Inactive

tedAir approved these changes

View reviewed changes

tedAir added the DC SOT 👌 label

tedAir temporarily deployed to milo_pr_merge

March 4, 2025 00:17

— with

GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge

March 4, 2025 01:11

— with

GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge

March 4, 2025 04:18

— with

GitHub Actions Inactive

sigadamvenkata approved these changes

View reviewed changes

sigadamvenkata added the CC SOT 👌 label

sigadamvenkata temporarily deployed to milo_pr_merge

March 4, 2025 08:17

— with

GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge

March 4, 2025 08:17

— with

GitHub Actions Inactive

milo-pr-merge bot merged commit 338fbec into main

48 checks passed

milo-pr-merge bot temporarily deployed to milo_pr_merge

March 4, 2025 08:45

Inactive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

github-actions[bot] github-actions[bot] left review comments

tedAir tedAir approved these changes

fullcolorcoder fullcolorcoder approved these changes

Dli3 Dli3 approved these changes

JackySun9 JackySun9 approved these changes

Roycethan Roycethan approved these changes

sigadamvenkata sigadamvenkata approved these changes

Brandon32 Awaiting requested review from Brandon32 Brandon32 is a code owner

meganthecoder Awaiting requested review from meganthecoder meganthecoder is a code owner

JasonHowellSlavin Awaiting requested review from JasonHowellSlavin JasonHowellSlavin is a code owner

salonijain3 Awaiting requested review from salonijain3 salonijain3 is a code owner

bandana147 Awaiting requested review from bandana147 bandana147 is a code owner

sharmrj Awaiting requested review from sharmrj sharmrj is a code owner

nishantka Awaiting requested review from nishantka nishantka is a code owner

Deva309 Awaiting requested review from Deva309 Deva309 is a code owner

sonawanesnehal3 Awaiting requested review from sonawanesnehal3 sonawanesnehal3 is a code owner

Labels

BAcom SOT 👌 CC SOT 👌 DC SOT 👌 Express SOT 👌 Homepage SOT 👌 MIQ SOT👌