Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mwpw 169166 autoblocks source2 #3872

Open
wants to merge 5 commits into
base: stage
Choose a base branch
from
Open

Conversation

zagi25
Copy link
Contributor

@zagi25 zagi25 commented Mar 27, 2025

Fix for reverted PR #3826

Autoblocks are only loaded from:

  • same origin
  • adobe.com or .adobe.com
  • auto block origins (e.g. instagram, youtube)
  • auto blocks coming from (aem/hlx).(page/live)
  • pdf has no restrictions as long as it has pdf extension in the url ( I didn't restrict this because of this pdf-viewer.js )

Resolves: MWPW-169166

Test URLs:

Hi @yesil and @bozojovicic I saw that you added new auto blocks recently (miniplans and m7), you used relative paths so I assume that the links will be either aem/hlx(same origin) or adobe.com and they will pass this check. Can you please confirm this ? Thank you.

@zagi25 zagi25 requested review from yesil, bozojovicic and a team March 27, 2025 10:01
Copy link
Contributor

aem-code-sync bot commented Mar 27, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Mar 27, 2025

Copy link
Contributor

@yesil yesil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

Copy link

@hit11757 hit11757 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants