Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing instanceName to the MssqlConnectionNode type #1063

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Add missing instanceName to the MssqlConnectionNode type #1063

merged 1 commit into from
Nov 13, 2024

Conversation

Imunal
Copy link
Contributor

@Imunal Imunal commented Nov 8, 2024

🔗 Linked issue

#916

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Add missing instanceName option in the MssqlConnectionNode type, which is required to setup if MSSQL is running using instance.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Imunal Imunal mentioned this pull request Nov 8, 2024
Closed
@thetutlage thetutlage merged commit dcec533 into adonisjs:21.x Nov 13, 2024
16 checks passed
@thetutlage
Copy link
Member

Thanks 👍

@Imunal Imunal deleted the add-missing-instanceName-in-mssql branch November 16, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Imunal @thetutlage