Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadcastable type doesn't support array #23

Closed
EvanPerreau opened this issue Jun 27, 2024 · 4 comments · Fixed by #24
Closed

Broadcastable type doesn't support array #23

EvanPerreau opened this issue Jun 27, 2024 · 4 comments · Fixed by #24
Labels
bug Something isn't working

Comments

@EvanPerreau
Copy link
Contributor

Package version

1.0.1

Describe the bug

image
the type Broadcastable doesn't support array

Reproduction repo

No response

@RomainLanz RomainLanz added the bug Something isn't working label Jun 27, 2024
@RomainLanz
Copy link
Member

Hey @EvanPerreau! 👋🏻

It seems to be a type issue. Can you confirm if the code works despite the typing error?

@EvanPerreau
Copy link
Contributor Author

Hello @RomainLanz,

Thanks for your reactivity. Yes, the code works perfectly except for the type error. Currently, I am using the //@ts-ignore annotation to avoid the type error. I am trying to pass an array in the transmit broadcast in a simple chat app, and it works perfectly ;)

It would be great if you could patch the bug. If you want, I can patch the bug and make a pull request to this repo.

@RomainLanz
Copy link
Member

Yes, happy to accept a PR!

@EvanPerreau
Copy link
Contributor Author

I fix this bug in the pull request #24 ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants