Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix - fixing typing issue for Broadcastable, now it's possible to have a payload with an array. #24

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Fix - fixing typing issue for Broadcastable, now it's possible to have a payload with an array. #24

merged 1 commit into from
Jun 28, 2024

Conversation

EvanPerreau
Copy link
Contributor

🔗 Linked issue

Issue #23

Broadcastable type doesn't support array

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Adding a supported type by Broadcastable: now it accepts arrays.
Resolves #23

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@EvanPerreau EvanPerreau mentioned this pull request Jun 28, 2024
Closed
@RomainLanz RomainLanz merged commit e588ef9 into adonisjs:develop Jun 28, 2024
5 checks passed
@RomainLanz
Copy link
Member

Thanks!

@EvanPerreau
Copy link
Contributor Author

Thank you for building AdonisJS 🤍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomainLanz RomainLanz RomainLanz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broadcastable type doesn't support array
2 participants
@EvanPerreau @RomainLanz