Skip to content

Commit

Permalink
Switch to electron-extension-installer
Browse files Browse the repository at this point in the history
electron-devtools-installer is old and unmaintained and uses a no-longer-supported API.

Fixes #1697
  • Loading branch information
bendemboski committed Apr 17, 2024
1 parent 62ca704 commit 43738a8
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ module.exports = {
allowModules: [
'devtron',
'electron',
'electron-devtools-installer',
'electron-extension-installer',
'ember-electron',
],
},
Expand Down
4 changes: 2 additions & 2 deletions forge/files/src/index.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
/* eslint-disable no-console */
const {
default: installExtension,
installExtension,
EMBER_INSPECTOR,
} = require('electron-devtools-installer');
} = require('electron-extension-installer');
const { pathToFileURL } = require('url');
const { app, BrowserWindow } = require('electron');
const path = require('path');
Expand Down
4 changes: 2 additions & 2 deletions forge/files/tests/index.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const {
default: installExtension,
installExtension,
EMBER_INSPECTOR,
} = require('electron-devtools-installer');
} = require('electron-extension-installer');
const path = require('path');
const { app } = require('electron');
const handleFileUrls = require('../src/handle-file-urls');
Expand Down
2 changes: 1 addition & 1 deletion forge/template.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class EmberElectronTemplates extends BaseTemplate {
return ['devtron'];
}
get dependencies() {
return ['electron-devtools-installer'];
return ['electron-extension-installer'];
}

async initializeTemplate(dir) {
Expand Down
2 changes: 1 addition & 1 deletion node-tests/fixtures/ember-test/test-index-extra.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// to make sure we don't have naming conflicts with already-declared variables
function testIndexExtra() {
// Make sure dependencies (node_modules) are loadable
require('electron-devtools-installer');
require('electron-extension-installer');

// Make sure local libraries are loadable
const helper = require('../src/helper');
Expand Down

0 comments on commit 43738a8

Please sign in to comment.