Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lambda Benchmarks From BumbleBench #1393

Merged
merged 1 commit into from
Oct 20, 2019
Merged

Conversation

piyush286
Copy link
Contributor

• Added parameters for changing BumbleBench repo and branch
• Added new benchmarks: DispatchBench, FibBench, GroupingBench & SieveBench
• Enabled new and existing tests for Java 11 along with Java 8

Issue: #1379

Signed-off-by: Piyush Gupta [email protected]

@piyush286
Copy link
Contributor Author

piyush286 commented Oct 11, 2019

I'm just enabling these tests for Java 8 and 11 for now since I was getting some build errors with Java 12, which I'll take a look in some future PR if that's okay.

8, Openj9
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/790/console
11, Openj9
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/791/console
8, Hotspot
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/792/console
11, Hotspot
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/793/console

Tests in all jobs passed except for one test in the 793 build:

18:12:20  Exception in thread "main" java.lang.RuntimeException: java.lang.NullPointerException
18:12:20  	at net.adoptopenjdk.bumblebench.core.Util.freshlyLoadedClass(Util.java:187)
18:12:20  	at net.adoptopenjdk.bumblebench.core.Util.newInstanceOfPossiblyFreshlyLoadedClass(Util.java:223)
18:12:20  	at net.adoptopenjdk.bumblebench.lambda.DispatchBench$InnerClasses.getCallee(DispatchBench.java:126)
18:12:20  	at net.adoptopenjdk.bumblebench.lambda.DispatchBench.computeCallees(DispatchBench.java:39)
18:12:20  	at net.adoptopenjdk.bumblebench.lambda.DispatchBench.<init>(DispatchBench.java:34)
18:12:20  	at net.adoptopenjdk.bumblebench.lambda.DispatchBench$InnerClasses.<init>(DispatchBench.java:124)
18:12:20  	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
18:12:20  	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
18:12:20  	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
18:12:20  	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490)
18:12:20  	at java.base/java.lang.Class.newInstance(Class.java:584)
18:12:20  	at net.adoptopenjdk.bumblebench.core.Launcher.main(Launcher.java:55)
18:12:20  Caused by: java.lang.NullPointerException
18:12:20  	at java.base/java.lang.reflect.Method.invoke(Method.java:559)
18:12:20  	at net.adoptopenjdk.bumblebench.core.Util.readFully(Util.java:196)
18:12:20  	at net.adoptopenjdk.bumblebench.core.Util.freshlyLoadedClass(Util.java:184)
18:12:20  	... 11 more
18:12:20  
18:12:20  bumbleBench-DispatchBench-InnerClasses_0_FAILED

Requesting review from @smlambert @llxia

buildenv/jenkins/JenkinsfileBase Outdated Show resolved Hide resolved
perf/bumbleBench/build.xml Outdated Show resolved Hide resolved
• Added new benchmarks: DispatchBench, FibBench, GroupingBench & SieveBench
• Enabled new and existing tests for Java 11 along with Java 8

Issue: adoptium#1379

Signed-off-by: Piyush Gupta <[email protected]>
@piyush286
Copy link
Contributor Author

piyush286 commented Oct 17, 2019

@smlambert Thanks for the review! I've made the suggested changes.

I'v enabled bumbleBench-DispatchBench-InnerClasses test for only OpenJ9 for now since it was failing with Java 11 Hotspot, for which I've opened an issue: adoptium/bumblebench#14.

Sanity Runs:

8, OpenJ9
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/840/console
15:49:06 TOTAL: 15 EXECUTED: 15 PASSED: 15 FAILED: 0 DISABLED: 0 SKIPPED: 0

11, Hotspot
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/841/console
15:49:09 TOTAL: 14 EXECUTED: 14 PASSED: 14 FAILED: 0 DISABLED: 0 SKIPPED: 0

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @piyush286 !
I will merge it once all this week's release jobs are completed (likely tomorrow).

@smlambert smlambert merged commit c53a8cf into adoptium:master Oct 20, 2019
@piyush286 piyush286 deleted the bumble branch October 21, 2019 17:05
@karianna karianna added this to the October 2019 milestone Oct 23, 2019
M-Davies pushed a commit to M-Davies/openjdk-tests that referenced this pull request Oct 25, 2019
• Added new benchmarks: DispatchBench, FibBench, GroupingBench & SieveBench
• Enabled new and existing tests for Java 11 along with Java 8

Issue: adoptium#1379

Signed-off-by: Piyush Gupta <[email protected]>
M-Davies added a commit to M-Davies/openjdk-tests that referenced this pull request Oct 25, 2019
author Morgan Davies <[email protected]> 1570612741 +0100
committer Morgan Davies <[email protected]> 1572013868 +0100

Removed CanAccessTest.java

Fixed in eclipse-openj9/openj9#7311

Removed DropLookupModeTest.java

Fixed in eclipse-openj9/openj9#7153

Updated problem list links

Perm exclude ModuleSetAccessibleTest.java

Removed DropLookupModeTest.java

Fixed in eclipse-openj9/openj9#6802

Removed InvokeMethodHandleWithBadArgument.java

Fixed in eclipse-openj9/openj9#6943

Updated links

Perm exclude TrySetAccessibleTest.java

squashed jdk-tests commits

skip B6206527 and B6521014 on macOS (adoptium#1390)

Remove block to re-download openjdk-test repo for debveloper branch (adoptium#1389)

Signed-off-by: [email protected] <[email protected]>

Make JAVA_BIN variable usable in MBCS_Tests  (adoptium#1387)

* Fix test environment check scripts and some test shells in MBCS_Tests

* Create set_variable.bat for test2.bat

Triage (adoptium#1392)

* Unexcluded RuntimeThreadInheritanceLeak

* Unexclude TestTerminatingThreadLocal

* Added issue for FilterUSRTest

Add Jenkins file to test Linux x86 32 bits platforms (adoptium#1395)

Add groovy script for Linux x86 32 bits test pipeline.

Signed-off-by: Violeta Sebe <[email protected]>

skip remaining ipv6 tests on macOS and skip TestZoneInfo310.java on all (adoptium#1398)

Add Lambda Benchmarks From BumbleBench (adoptium#1393)

• Added new benchmarks: DispatchBench, FibBench, GroupingBench & SieveBench
• Enabled new and existing tests for Java 11 along with Java 8

Issue: adoptium#1379

Signed-off-by: Piyush Gupta <[email protected]>

Set correct test repo for aarch64 builds (adoptium#1403)

Fix git repo for jdk8 aarch64 (adoptium#1404)

* Turn off sbt colour formatting

Signed-off-by: smlambert <[email protected]>

* Update jdk8 aarch64 git repo

Signed-off-by: smlambert <[email protected]>

* Fix nested if

Signed-off-by: smlambert <[email protected]>

Reorganize JCK targets (adoptium#1401)

Signed-off-by: [email protected] <[email protected]>

Fix external/system-test apache-ant uri (adoptium#1405)

Add -q option back in git cmd (adoptium#1407)

The full console output is too long to load, so add back quite option in
git cmd

Signed-off-by: lanxia <[email protected]>

Fix MBCS_Tests_CLDR_11 testcase and several minor changes (adoptium#1406)

* Fix CLDR_11 testcase and several minor changes
* Fix MBCS_Tests.unicode testcase

skip B6206527 and B6521014 on macOS (adoptium#1390)

Remove block to re-download openjdk-test repo for debveloper branch (adoptium#1389)

Signed-off-by: [email protected] <[email protected]>

Make JAVA_BIN variable usable in MBCS_Tests  (adoptium#1387)

* Fix test environment check scripts and some test shells in MBCS_Tests

* Create set_variable.bat for test2.bat

squashing past 15 commits on jdk-tests

Triage (adoptium#1392)

* Unexcluded RuntimeThreadInheritanceLeak

* Unexclude TestTerminatingThreadLocal

* Added issue for FilterUSRTest

Add Jenkins file to test Linux x86 32 bits platforms (adoptium#1395)

Add groovy script for Linux x86 32 bits test pipeline.

Signed-off-by: Violeta Sebe <[email protected]>

skip remaining ipv6 tests on macOS and skip TestZoneInfo310.java on all (adoptium#1398)

Add Lambda Benchmarks From BumbleBench (adoptium#1393)

• Added new benchmarks: DispatchBench, FibBench, GroupingBench & SieveBench
• Enabled new and existing tests for Java 11 along with Java 8

Issue: adoptium#1379

Signed-off-by: Piyush Gupta <[email protected]>

Set correct test repo for aarch64 builds (adoptium#1403)

Fix git repo for jdk8 aarch64 (adoptium#1404)

* Turn off sbt colour formatting

Signed-off-by: smlambert <[email protected]>

* Update jdk8 aarch64 git repo

Signed-off-by: smlambert <[email protected]>

* Fix nested if

Signed-off-by: smlambert <[email protected]>

Reorganize JCK targets (adoptium#1401)

Signed-off-by: [email protected] <[email protected]>

Fix external/system-test apache-ant uri (adoptium#1405)

Add -q option back in git cmd (adoptium#1407)

The full console output is too long to load, so add back quite option in
git cmd

Signed-off-by: lanxia <[email protected]>

Fix MBCS_Tests_CLDR_11 testcase and several minor changes (adoptium#1406)

* Fix CLDR_11 testcase and several minor changes
* Fix MBCS_Tests.unicode testcase

conflicts cropped up again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants