Potential DoS with NumberFilter conversion to integer values.
High severity
GitHub Reviewed
Published
Sep 27, 2020
in
carltongibson/django-filter
•
Updated Sep 16, 2024
Description
Reviewed
Sep 28, 2020
Published to the GitHub Advisory Database
Sep 28, 2020
Published by the National Vulnerability Database
Apr 29, 2021
Last updated
Sep 16, 2024
Impact
Automatically generated
NumberFilter
instances, whose value was later converted to an integer, were subject to potential DoS from maliciously input using exponential format with sufficiently large exponents.Patches
Version 2.4.0+ applies a
MaxValueValidator
with a a defaultlimit_value
of 1e50 to the form field used byNumberFilter
instances.In addition,
NumberFilter
implements the newget_max_validator()
which should return a configured validator instance to customise the limit, or elseNone
to disable the additional validation.Workarounds
Users may manually apply an equivalent validator if they are not able to upgrade.
For more information
If you have any questions or comments about this advisory:
Thanks to Marcin Waraksa for the report.
References