Split the author call in the library stats page to 2 lighter functions #2896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
used a lighter function to find total author count
getAuthorsWithCount - now only gets the top 10 authors (in that library) by number of books getAuthorsTotalCount - new function to only get total number of authors (in that library)
nichwall
reviewed
May 1, 2024
As per nichwall's request
- Clarified and updated the comments - added parameter "limit" to getAuthorsWithCount() - the limit is set to 10 when called from LibraryController.js - as per Nichwall's comments
|
This PR is working for me when tested against my main database. |
|
LGTM thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on the library stats page, the function getAuthorsWithCount() is called to get both the top 10 authors by number of books, and also the total number of authors in that library. It does this by querying for all authors and every related book. In a library of 30k authors, this query takes
567038msor around 10 minutes.This has been split into 2 calls - getAuthorsTotalCount() gets the total number of authors in the library in
1msand getAuthorsWithCount() only grabs the top 10 authors by number of books written in35ms. These values will vary based n the number of books in the library, but it represents a significant speed increase.The results displayed on the stats page should be identical after the change.