Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add item sessions endpoint #2920

Merged
merged 5 commits into from
May 23, 2024
Merged

Add item sessions endpoint #2920

merged 5 commits into from
May 23, 2024

Conversation

rasmuslos
Copy link
Contributor

This endpoint allows API clients to request listing sessions for specific items. A possible use case for this would be to show the listing session of an audiobook on its page.

@advplyr
Copy link
Owner

advplyr commented May 8, 2024

I doubt this would fulfill that FR because even pausing long enough isn't going to end the session. Sessions in Abs need to be refactored to handle that better. I guess it could be useful to see sessions for a specific audiobook but I don't think it will provide much use for tracking. The Abs android app has that feature and it is all tracked internally. It hasn't been added to the iOS app yet advplyr/audiobookshelf-app#466.

server/controllers/MeController.js Outdated Show resolved Hide resolved
server/controllers/MeController.js Outdated Show resolved Hide resolved
server/routers/ApiRouter.js Outdated Show resolved Hide resolved
@advplyr
Copy link
Owner

advplyr commented May 8, 2024

Sorry for the quick review, not much time today. Pointed out a few things

@rasmuslos
Copy link
Contributor Author

I doubt this would fulfill that FR because even pausing long enough isn't going to end the session. Sessions in Abs need to be refactored to handle that better. I guess it could be useful to see sessions for a specific audiobook but I don't think it will provide much use for tracking. The Abs android app has that feature and it is all tracked internally. It hasn't been added to the iOS app yet advplyr/audiobookshelf-app#466.

I think it's better than nothing and having play / pause show up is not really necessary (in my opinion). Also clients could just close the active listing session after x minutes of inactivity.

@advplyr
Copy link
Owner

advplyr commented May 23, 2024

Thanks!

@advplyr advplyr merged commit d99a778 into advplyr:master May 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants