Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix series and collapsed series progress to be consistent and show average of book series progress #2954

Merged
merged 9 commits into from
May 12, 2024

Conversation

mikiher
Copy link
Contributor

@mikiher mikiher commented May 9, 2024

This fixes #2921.

In a nutshell, the changes are:

  • Correct series and collapsed series progress bars to show the same
    • The series card in the Series page and collapsed series book card display the same progress.
    • The progress displayed is now the average of the series books progress (i.e. the sum of all the series individual book progresses, divided by the number of books in the series)
  • Added libraryItemIds to collapsedSeries objects return from the server
    • This fixes the bug in seriesIsFinished in LazyBookCard, which currently always returns true
  • Simplified progress bar logic in LazyBookCard

@mikiher mikiher marked this pull request as ready for review May 9, 2024 05:13
@mikiher
Copy link
Contributor Author

mikiher commented May 10, 2024

Also added some component tests for LazyBookCard, especially around collapsedSeries cards.

@advplyr
Copy link
Owner

advplyr commented May 12, 2024

Great, thanks!

@advplyr advplyr merged commit dc0eaa3 into advplyr:master May 12, 2024
4 checks passed
@mikiher mikiher deleted the series-progress-fixes branch May 13, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Series and collapesed series progress bars are buggy
2 participants