Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a try-catch block around custom provider search #3396

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Add a try-catch block around custom provider search #3396

merged 1 commit into from
Sep 9, 2024

Conversation

mikiher
Copy link
Contributor

@mikiher mikiher commented Sep 9, 2024

This fixes #3390.

CustomProviderAdapter.search has the potential to throw errors that weren't caught by the caller.

@mikiher mikiher marked this pull request as ready for review September 9, 2024 16:26
@advplyr
Copy link
Owner

advplyr commented Sep 9, 2024

Thanks!

@advplyr advplyr merged commit 7a0cd1e into advplyr:master Sep 9, 2024
5 checks passed
@mikiher mikiher deleted the custom-provider-try-catch branch September 9, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Malformed request in Custom Metadata Provider crashes the ABS server
2 participants
@mikiher @advplyr