-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: unified package #3639
Open
wommy
wants to merge
1
commit into
advplyr:master
Choose a base branch
from
wommy:feat-unifiedPackage
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: unified package #3639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Total potential size reduction: ~14.4MB Major categories for removal/replacement:
all from claude https://claude.site/artifacts/d2693141-8043-4ebb-ad92-45991ede362b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary
unified
client/package.json
into rootpackage.json
Which issue is fixed?
no specific issue,
but because there arent two
package.json
's anymore,everything can just be ran from rootDir
eliminates the need for two
npm ci
'ssimplifies the install and generation of the app
in the migration from nuxt 2 to 3, 3 comes with a
/server/
directoryhttps://nuxt.com/docs/guide/directory-structure/server
tho i will still have to migrate all the logic from express into nitro and h3
https://h3.unjs.io/examples/from-expressjs-to-h3
i think it will be well worth it: removing dozens of outdate dependencies and boilerplate code, while simplifying logic and getting a nice speed increase
ill post a nice chatgpt analysis of that whenever my credits refill tomorrow
In-depth Description
cd client
git mv assets components layouts middleware mixins pages players plugins store strings cypress cypress.config.js nuxt.config.js tailwind.config.js ..
mv dist public static .nuxt ..
cd ..
scripts
, dependencies:deps
,dev
, andoptional
, fromclient/package.json
intopackage.json
, plus a few other misc edits, check the filegit rm -r client/
server/Server.js
from/client/dist/
to/dist/
.gitignore
npm install
sonpmci
would worknpm audit fix
to fix the fixable npm errors 59 => 42 cli linknpm dedupe
to remove ~75 duplicated packages fromnode_modules
cli linkHow have you tested this?
yes of course,
rm -rf node_modules
npm run client ; npm start
localhost:3333
and everything was perfectly there
i only have an epub and an audiobook, but they both played perfectly,
i navigated to each different view they all work normally,
which tracks because i didnt edit anything on the server
other than removing the
/client
prefix from the static app directoryScreenshots
no client changes
Additional - Left Undone - Unsure How to Proceed
i didnt edit a few misc files, ill split them into categories
simple
.devcontainer/post-create.sh
,.vscode/launch.json
,.vscode/tasks.json
.dockerignore
.gitignore
medium
Dockerfile
STAGE 0 WORKDIR
works, looks simple thoharder
.github/workflows
/client
w/assets components layouts middleware mixins pages players plugins static store strings cypress cypress.config.js nuxt.config.js tailwind.config.js