Re-sort title-sorted bookshelf after title change #4008
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary
When a bookshelf is sorted by title and the title of a book/podcast changes (e.g. after being edited), the bookshelf is rebuilt so the book appears at its proper position (based on its new title)
Which issue is fixed?
Fixes #3998
In-depth Description
Up until now, when
LazyBookshelf
got anitem_updated
message from the server, it only replaced the old entity with the updated entity. With this change, if the current sort order is by title, and a change of title is detected,resetEntities()
is called, and the item is moved to its new position.How have you tested this?
Changed title of books/podcasts and verified that after saving the change, the book/podcast moved to its new position.