Test against PHP 8.3 #113
Closed
Test against PHP 8.3 #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norberttech
reviewed
Dec 18, 2023
| @@ -116,6 +116,7 @@ jobs: | |||
| php-version: | |||
| - "8.1" | |||
| - "8.2" | |||
| - "8.3" | |||
There was a problem hiding this comment.
hmm I'm not even sure why this is not failing, all composer.json files require PHP ~8.1 || ~8.2 and 8.3 should not satisfy constraint ~8.2
There was a problem hiding this comment.
nvm, it works because composer handles ~8.2 differently, I missed that when I created those constraints.
Composer handles tilde constraint differently. Your constraint will translate to >=8.2.0 <9.0.0.
Those constraints should be first changed to ~8.2.0 in order to allow only for 8.2.* without 8.3, and then we should explicitly add everywhere ~8.3.0 and only then enable 8.3 on GitHub pipelines.
|
Closing this for now as there are few other things that needs to be changed first, it all can come in a one bigger batch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Log
Added
Fixed
Changed
Updated
Removed
Deprecated
Security
Description