-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Included RSAST as a alternative to SAST (2.0) #1383
Conversation
Thank you for contributing to
|
Hello, I have another question, I'm using two new libraries "statsmodels" and "scipy". How can I included in aeon these libraries since it seems it is generating conflict? |
scipy is fine, statsmodels will have to be added as a tag i.e. https://github.com/aeon-toolkit/aeon/blob/main/aeon/classification/shapelet_based/_ls.py#L95 Check out the contributing guide for some tips. The developer install would be helpful for pre-commit. |
The tag also has to be included for the transformer, and the imports must be inside the function rather than at the top of the file. |
I think the remaining failure is because of the examples. No good way to get around this unfortunately, I would recommend using |
Ok @MatthewMiddlehurst thanks, it seems the validation worked for the library issues. However there are still errors in "pre-commit" and there is no a detail about why they are caused. |
These are our code quality checks, for the most part it is probably white space. I would recommend following the pre-commit section of the dev install guide or I can run it through at some point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, a few minor things, thanks very much for the contribution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, sorry for the delay
We are releasing next week, this should be available then. |
What does this implement/fix? Explain your changes.
I included a transformer RSAST and a classifier RSASTClassifier which are tools to use in time series classification. The method RSAST is based on shapelets in order to transform dataset of Time Series.
Does your contribution introduce a new dependency? If yes, which one?
Yes, I used f_oneway, DegenerateDataWarning, ConstantInputWarning from the "scipy.stats" toolkit. Also, acf and pacf from the "statsmodels.tsa.stattools" implementation.
PR checklist
For all contributions
For new estimators and functions
__maintainer__
at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access