-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Included RSAST as a alternative to SAST #1362
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Thank you for contributing to
|
Hi, I'm new to using forks on github. I already changed the init.py file, including a "LearningShapeletClassifier" classifier that I thought was causing conflicts with the code I'm trying to merge. However, I have not been able to complete the PR. What else should I check to correctly modify the code? Thanks for the help. |
Hi @nirojasva, you will want to pull from the main How different is this from the original SAST, can it be integrated into that implementation instead? I think @TonyBagnall reviewed the original? |
Yes, it is a little bit different since in SAST every subsequence in time series is extracted for the transformation of dataset and in RSAST just some randomly selected shapelet are used to do the transformation. I have about the validation, if I make push from my local aeon github project it will automaticlly recalcalculate the conflicts? Thanks, |
It sounds like this could be in the same classifier as the regular SAST as a parameter (like the ROCKET variants). If the transformer can't be in the same class, it could be in the same file to keep it more organised.
No, you will have to pull the |
It seems now is merged, thanks. |
For this branch it looks like you overwrote the contents with main rather then merging. You may have to create a new PR, or maybe adding new changes will reopen. |
I tried to create another PR: [ENH] Included RSAST as a alternative to SAST (2.0) #1383 |
What does this implement/fix? Explain your changes.
I included a transformer RSAST and a classifier RSASTClassifier which are tools to use in time series classification. The method RSAST is based on shapelets in order to transform dataset of Time Series.
Does your contribution introduce a new dependency? If yes, which one?
Yes, I used f_oneway, DegenerateDataWarning, ConstantInputWarning from the "scipy.stats" toolkit. Also, acf and pacf from the "statsmodels.tsa.stattools" implementation.
PR checklist
For all contributions
For new estimators and functions
__maintainer__
at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access