Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Included RSAST as a alternative to SAST #1362

Closed
wants to merge 0 commits into from

Conversation

nirojasva
Copy link
Contributor

@nirojasva nirojasva commented Apr 2, 2024

What does this implement/fix? Explain your changes.

I included a transformer RSAST and a classifier RSASTClassifier which are tools to use in time series classification. The method RSAST is based on shapelets in order to transform dataset of Time Series.

Does your contribution introduce a new dependency? If yes, which one?

Yes, I used f_oneway, DegenerateDataWarning, ConstantInputWarning from the "scipy.stats" toolkit. Also, acf and pacf from the "statsmodels.tsa.stattools" implementation.

PR checklist

For all contributions
  • I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you.
  • The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.
For new estimators and functions
  • I've added the estimator to the online API documentation.
  • (OPTIONAL) I've added myself as a __maintainer__ at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.
For developers with write access
  • (OPTIONAL) I've updated aeon's CODEOWNERS to receive notifications about future changes to these files.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@aeon-actions-bot aeon-actions-bot bot added classification Classification package examples Example notebook related transformations Transformations package labels Apr 2, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I did not find any labels to add based on the title. Please add the [ENH], [MNT], [BUG], [DOC], [REF], [DEP] and/or [GOV] tags to your pull requests titles. For now you can add the labels manually.
I have added the following labels to this PR based on the changes made: [ $\color{#BCAE15}{\textsf{classification}}$, $\color{#45FD64}{\textsf{examples}}$, $\color{#41A8F6}{\textsf{transformations}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

@nirojasva nirojasva changed the title Included RSAS as a alternative to SAST ENH: Included RSAS as a alternative to SAST Apr 2, 2024
@MatthewMiddlehurst MatthewMiddlehurst changed the title ENH: Included RSAS as a alternative to SAST [ENH] Included RSAS as a alternative to SAST Apr 2, 2024
@MatthewMiddlehurst MatthewMiddlehurst added the enhancement New feature, improvement request or other non-bug code enhancement label Apr 2, 2024
@nirojasva nirojasva changed the title [ENH] Included RSAS as a alternative to SAST [ENH] Included RSAST as a alternative to SAST Apr 2, 2024
@nirojasva
Copy link
Contributor Author

Hi, I'm new to using forks on github. I already changed the init.py file, including a "LearningShapeletClassifier" classifier that I thought was causing conflicts with the code I'm trying to merge. However, I have not been able to complete the PR. What else should I check to correctly modify the code? Thanks for the help.

@MatthewMiddlehurst
Copy link
Member

Hi @nirojasva, you will want to pull from the main branch main repository remote aeon-toolkit/aeon, then resolve any conflicts.

How different is this from the original SAST, can it be integrated into that implementation instead? I think @TonyBagnall reviewed the original?

@nirojasva
Copy link
Contributor Author

Hi @MatthewMiddlehurst,

Yes, it is a little bit different since in SAST every subsequence in time series is extracted for the transformation of dataset and in RSAST just some randomly selected shapelet are used to do the transformation.

I have about the validation, if I make push from my local aeon github project it will automaticlly recalcalculate the conflicts?

Thanks,

@MatthewMiddlehurst
Copy link
Member

It sounds like this could be in the same classifier as the regular SAST as a parameter (like the ROCKET variants). If the transformer can't be in the same class, it could be in the same file to keep it more organised.

I have about the validation, if I make push from my local aeon github project it will automaticlly recalcalculate the conflicts?

No, you will have to pull the main branch first. After merging there, you can then push the merged commits to your branch and it will update here.

@nirojasva
Copy link
Contributor Author

It seems now is merged, thanks.

@MatthewMiddlehurst
Copy link
Member

For this branch it looks like you overwrote the contents with main rather then merging. You may have to create a new PR, or maybe adding new changes will reopen.

@nirojasva
Copy link
Contributor Author

I tried to create another PR: [ENH] Included RSAST as a alternative to SAST (2.0) #1383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
classification Classification package enhancement New feature, improvement request or other non-bug code enhancement examples Example notebook related transformations Transformations package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants