Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEP] Move HampelFilter to outliers #1538

Closed
wants to merge 2 commits into from
Closed

[DEP] Move HampelFilter to outliers #1538

wants to merge 2 commits into from

Conversation

TonyBagnall
Copy link
Contributor

@TonyBagnall TonyBagnall commented May 17, 2024 •
edited
Loading

Deprecates the HampelFilter transformer and moves functionality to anomaly detection, as discussed on slack

part of #1446

@TonyBagnall TonyBagnall added transformations Transformations package anomaly detection Anomaly detection package deprecation This issue is related to deprecation or removal of code labels May 17, 2024
@TonyBagnall TonyBagnall requested a review from aiwalter as a code owner May 17, 2024 15:16
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I would have added the following labels to this PR based on the changes made: [ $\color{#6F6E8D}{\textsf{anomaly detection}}$, $\color{#41A8F6}{\textsf{transformations}}$ ], however some package labels are already present.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

@TonyBagnall TonyBagnall mentioned this pull request May 17, 2024
Closed
35 tasks
SebastianSchmidl
SebastianSchmidl reviewed May 21, 2024
View reviewed changes
aeon/transformations/outlier_detection.py
@deprecated(
version="0.9.0",
reason="The HampelFilter transformer will be removed in v0.10.0 and will be "
"replaced by an anomaly detector with ",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with what?

MatthewMiddlehurst
MatthewMiddlehurst reviewed May 21, 2024
View reviewed changes
aeon/anomaly_detection/_hampel.py
Comment on lines +46 to +52
_tags = {
"input_data_type": "Series",
"output_data_type": "Series",
"X_inner_type": ["pd.DataFrame", "pd.Series"],
"capability:missing_values": True,
"capability:multivariate": True,
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are outdated now.

aeon/anomaly_detection/_hampel.py
Comment on lines +74 to +75
Xt : pd.Series or pd.DataFrame, same type as X
transformed version of X
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, a lot of the documentation does not seem to fit with the move.

aeon/anomaly_detection/_hampel.py
Comment on lines +79 to +82
# multivariate
if isinstance(Z, pd.DataFrame):
for col in Z:
Z[col] = self._predict_outliers(Z[col])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think testing may not be working as intended if this is passing

@TonyBagnall TonyBagnall closed this Jun 8, 2024
@TonyBagnall TonyBagnall deleted the ajb/hampel branch October 7, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthewMiddlehurst MatthewMiddlehurst MatthewMiddlehurst left review comments

@SebastianSchmidl SebastianSchmidl SebastianSchmidl left review comments

@aiwalter aiwalter Awaiting requested review from aiwalter

Assignees
No one assigned
Labels
anomaly detection Anomaly detection package deprecation This issue is related to deprecation or removal of code transformations Transformations package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TonyBagnall @SebastianSchmidl @MatthewMiddlehurst