Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Fix CODEOWNERS file #1554

Merged
merged 1 commit into from
May 22, 2024
Merged

[BUG]: Fix CODEOWNERS file #1554

merged 1 commit into from
May 22, 2024

Conversation

SebastianSchmidl
Copy link
Member

@SebastianSchmidl SebastianSchmidl commented May 22, 2024

Reference Issues/PRs

None, maybe #1095

What does this implement/fix? Explain your changes.

image

  • removes @ermshaua, not a core dev
  • fixes name of code of conduct team

Does your contribution introduce a new dependency? If yes, which one?

Nope

@SebastianSchmidl SebastianSchmidl added bug Something isn't working maintenance Continuous integration, unit testing & package distribution no changelog PR should not be added to the changelog labels May 22, 2024
@SebastianSchmidl SebastianSchmidl self-assigned this May 22, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I did not find any labels to add that did not already exist. If the content of your PR changes, make sure to update the labels accordingly.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

@SebastianSchmidl
Copy link
Member Author

It is unclear to me why GitHub still complains about @aeon-toolkit/aeon-code-of-conduct-workgroup It does exist: https://github.com/orgs/aeon-toolkit/teams/aeon-code-of-conduct-workgroup

Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, CoCC issue was that the group did not have write access. I have changed the group permissions.

@SebastianSchmidl SebastianSchmidl merged commit 689a3dd into main May 22, 2024
3 checks passed
@SebastianSchmidl SebastianSchmidl deleted the fix/codeowners branch May 22, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance Continuous integration, unit testing & package distribution no changelog PR should not be added to the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants