-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Check data shape in predict
-like functions
#1865
Conversation
Thank you for contributing to
|
@TonyBagnall @hadifawaz1999 do these changes seem reasonable? DLs are breaking, but i think that is more of a DL issues than the changes here. |
@MatthewMiddlehurst not only DL seems dictionary based are failing too here |
It likely has to do with no longer allowing storage of metadata via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good just a couple of comments @MatthewMiddlehurst
…emove-checks # Conflicts: # aeon/base/tests/test_base_collection.py
basic structure looks good to me |
@chrisholder any issue with the cache change? currently I think it runs when collecting tests, or at least it did for some reason locally. |
@hadifawaz1999 there was a conflict with the testing PRs, could you approve again? |
Reference Issues/PRs
Fixes #1774
Fixes #1775
Fixes #1936
Fixes #1966
What does this implement/fix? Explain your changes.
Adds a check to collection base classes which raises an error if length and channels does not match fit. Removed redundant check from interval base class.