Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Check data shape in predict-like functions #1865

Merged
merged 11 commits into from
Aug 13, 2024

Conversation

MatthewMiddlehurst
Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst commented Jul 29, 2024

Reference Issues/PRs

Fixes #1774
Fixes #1775
Fixes #1936
Fixes #1966

What does this implement/fix? Explain your changes.

Adds a check to collection base classes which raises an error if length and channels does not match fit. Removed redundant check from interval base class.

@aeon-actions-bot aeon-actions-bot bot added the bug Something isn't working label Jul 29, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#d73a4a}{\textsf{bug}}$ ].
This PR changes too many different packages (>3) for automatic addition of labels, please manually add package labels if relevant.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Push an empty commit to re-run CI checks

@MatthewMiddlehurst
Copy link
Member Author

@TonyBagnall @hadifawaz1999 do these changes seem reasonable? DLs are breaking, but i think that is more of a DL issues than the changes here.

@MatthewMiddlehurst MatthewMiddlehurst marked this pull request as ready for review July 30, 2024 21:03
@MatthewMiddlehurst MatthewMiddlehurst added classification Classification package clustering Clustering package regression Regression package labels Jul 30, 2024
@hadifawaz1999
Copy link
Member

hadifawaz1999 commented Jul 31, 2024

@MatthewMiddlehurst not only DL seems dictionary based are failing too here
is there something that these changes assume sub classes are doing ? because it seems it assumes n_timepoints is an attribute somewhere defined, which most sub classes don't do

@MatthewMiddlehurst
Copy link
Member Author

It likely has to do with no longer allowing storage of metadata via predict. Just want to make sure the current changes are fine before we fix any of the broken stuff.

Copy link
Member

@hadifawaz1999 hadifawaz1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good just a couple of comments @MatthewMiddlehurst

@TonyBagnall
Copy link
Contributor

basic structure looks good to me

@MatthewMiddlehurst
Copy link
Member Author

@chrisholder any issue with the cache change? currently I think it runs when collecting tests, or at least it did for some reason locally.

hadifawaz1999
hadifawaz1999 previously approved these changes Aug 12, 2024
@MatthewMiddlehurst
Copy link
Member Author

@hadifawaz1999 there was a conflict with the testing PRs, could you approve again?

@MatthewMiddlehurst MatthewMiddlehurst merged commit 447a487 into main Aug 13, 2024
13 of 14 checks passed
@MatthewMiddlehurst MatthewMiddlehurst deleted the mm/remove-checks branch August 13, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working classification Classification package clustering Clustering package regression Regression package
Projects
None yet
3 participants