-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNT] Swapped tensorflow and pytorch to install only CPU version #2416
Conversation
Thank you for contributing to
|
Do not merge this yet need to get rid of the additional periodic test which I turned on just for this branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- why only linux?
- doesn't this still install tensorflow and torch through
all_extras
? - wouldnt we want to still install the gpu versions somewhere in the testing workflows?
why only linux? Windows: Macos: The same is true for Torch macos doesn't support GPU, and windows you have to specify additional parameters to get the GPU version (which we don't currently do). doesn't this still install tensorflow and torch through wouldnt we want to still install the gpu versions somewhere in the testing workflows? |
ok, let me know when its ready |
Ready for review @MatthewMiddlehurst |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Reference Issues/PRs
#2415
What does this implement/fix? Explain your changes.
This PR adds a custom github action when installing all_extras on ubuntu. The custom action installs tensorflow-cpu and pytorch cpu instead of the "normal" version which comes with all the GPU code. By installing the CPU version it saves considerable install time but in addition saves a considerable amount of RAM usage during the test running (as the package sizes are dramatically smaller). This should help to prevent issues causing the CI to crash due to exceeding memory limits.
Does your contribution introduce a new dependency? If yes, which one?
Any other comments?
PR checklist
For all contributions
For new estimators and functions
__maintainer__
at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access