-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] RDSTClassifier and transformer tests #529
[ENH] RDSTClassifier and transformer tests #529
Conversation
…istance instead of euclidean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will get back to you Re: MacOS if i can figure it out
Macs are miserable. But either the latest commit solves the different results or my VM does not work as intended. Tried for a while to get a UEA Macbook working then found an old setup for Catch22 which used to have the same issue! |
I was getting numba type error for passing a RandomState object to |
Nope, I would just remove/skip/comment out the test for now. Setting up a Mac will take a little bit more work on my end unless anyone else can get one. |
I added some checks and the end of the fit method to avoid cases where we have no shapelets or NaN values in the shapelets values. So now more informative errors will be raised if these cases happen. Tests for the classifier seem to be OK on MacOS. |
Also there appears to be an out of index error on one of the numba functions, see https://github.com/aeon-toolkit/aeon/actions/runs/5565449870/jobs/10165816706 (numba does not check for this by default) |
This is due to a mistake in the data given to the function in the test for. This should now work as intended, I needed to transpose the array to have the expected shape from the testing data. This should not impact normal execution as the correct shape is given by the |
Is the readthedocs issue due to something wrong with the docs ? Only see a timeout on the errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Docs issue is not related to this PR, happening on other PRs and we have to figure out why!
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Does your contribution introduce a new dependency? If yes, which one?
No.
What should a reviewer concentrate their feedback on?
Check if the implementation of RDSTClassifier is matching the standards of aeon.
Did you add any tests for the change?
I added a default test parameter set for the
get_test_params
method.PR checklist
For all contributions