Fixing incorrect comments and DS names #349

matzew · 2014-08-08T19:29:02Z

💄

small improvements on comment (e.g. incorrect DS and Server names)
added MySQL URL escaping for WildFly CLI script, like @mposolda did for the EAP/mysql script

matzew · 2014-08-08T19:46:59Z

🎯 @secondsun @danielpassos @danbev mind to review ?

secondsun · 2014-08-08T20:47:06Z

So the datasources are created (yay) but I couldn't test that they actually work because the server fails building because drumroll please JAVADOC ERRORS :) (in Java 8 of course.)

Bonus points, jax-doclets isn't maintained anymore (FroMage/jax-doclets#61 (comment)) HOWEVER some guys from marmot patched it and release 0.10.1 which does work in Java 8.

I patched up the pom to use the new version, but it doesn't seem to work. Output

matzew · 2014-08-08T21:23:40Z

use java7 - that's what we, for the server, support.
Alternative way: use the staged WAR files for 1.0.0.beta2

On Fri, Aug 8, 2014 at 10:47 PM, Hoyt Summers Pittman <
[email protected]> wrote:

So the datasources are created (yay) but I couldn't test that they
actually work because the app fails building drumroll please JAVADOC
ERRORS :) Java 8 of course.

Bonus points, jax-doclets isn't maintained anymore (FroMage/jax-doclets#61
(comment)
FroMage/jax-doclets#61 (comment))
HOWEVER some guys from marmot patched it and release 0.10.1 which does work
in Java 8.

I patched up the pom to use the new version, but it doesn't seem to work.
Output https://gist.github.com/secondsun/0bc4ef1563d3e291e2b3

—
Reply to this email directly or view it on GitHub
#349 (comment)
.

Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf

abstractj · 2014-08-11T13:07:32Z

Tested locally here with Java 7 and works fine. For Java 8 we're planning to discuss during our meeting today.
I think this PR doesn't not add any issues with doclint, once it was always there.

secondsun · 2014-08-11T14:00:36Z

@matzew Ok, java 7 things build etc. 👍 Like I said before your changes actually work. Though on wildfly 8.0.0 there is a bug with mysql's connector jar on version 30+ which is fixed in 8.1.0.

matzew · 2014-08-11T14:02:38Z

cool

regarding the mysql. the doc uses mysql-connector-java-5.1.18.jar

On Mon, Aug 11, 2014 at 4:00 PM, Hoyt Summers Pittman <
[email protected]> wrote:

@matzew https://github.com/matzew Ok, java 7 things build etc. [image:
👍] Like I said before your changes actually work. Though on wildfly
8.0.0 there is a bug with mysql's connector jar on version 30+ which is
fixed in 8.1.0.

—
Reply to this email directly or view it on GitHub
#349 (comment)
.

Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf

secondsun · 2014-08-11T14:20:43Z

I didn't see a version mentioned in the docs. I only saw it mentioned in
the code. I don't THINK we are including the mysql-connector in the
releases, are we?

Summers Pittman

Phone:404 941 4698
Java is my crack.

On Mon, Aug 11, 2014 at 10:02 AM, Matthias Wessendorf <
[email protected]> wrote:

cool

regarding the mysql. the doc uses mysql-connector-java-5.1.18.jar

On Mon, Aug 11, 2014 at 4:00 PM, Hoyt Summers Pittman <
[email protected]> wrote:

@matzew https://github.com/matzew Ok, java 7 things build etc.
[image:
👍] Like I said before your changes actually work. Though on wildfly
8.0.0 there is a bug with mysql's connector jar on version 30+ which is
fixed in 8.1.0.

—
Reply to this email directly or view it on GitHub
<
https://github.com/aerogear/aerogear-unifiedpush-server/pull/349#issuecomment-51783545>

.

Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf

—

Reply to this email directly or view it on GitHub
#349 (comment)
.

matzew · 2014-08-11T14:27:49Z

nope - we are not shipping the mysql jar

On Mon, Aug 11, 2014 at 4:20 PM, Hoyt Summers Pittman <
[email protected]> wrote:

I didn't see a version mentioned in the docs. I only saw it mentioned in
the code. I don't THINK we are including the mysql-connector in the
releases, are we?

Summers Pittman

Phone:404 941 4698
Java is my crack.

On Mon, Aug 11, 2014 at 10:02 AM, Matthias Wessendorf <
[email protected]> wrote:

cool

regarding the mysql. the doc uses mysql-connector-java-5.1.18.jar

On Mon, Aug 11, 2014 at 4:00 PM, Hoyt Summers Pittman <
[email protected]> wrote:

@matzew https://github.com/matzew Ok, java 7 things build etc.
[image:
👍] Like I said before your changes actually work. Though on wildfly
8.0.0 there is a bug with mysql's connector jar on version 30+ which
is
fixed in 8.1.0.

—
Reply to this email directly or view it on GitHub
<

https://github.com/aerogear/aerogear-unifiedpush-server/pull/349#issuecomment-51783545>

.

Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf

—

Reply to this email directly or view it on GitHub
<
https://github.com/aerogear/aerogear-unifiedpush-server/pull/349#issuecomment-51783798>

.

—
Reply to this email directly or view it on GitHub
#349 (comment)
.

Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf

secondsun · 2014-08-11T15:07:39Z

Can you link me the doc that references the jar version?
On Aug 11, 2014 10:27 AM, "Matthias Wessendorf" [email protected]
wrote:

nope - we are not shipping the mysql jar

On Mon, Aug 11, 2014 at 4:20 PM, Hoyt Summers Pittman <
[email protected]> wrote:

I didn't see a version mentioned in the docs. I only saw it mentioned in
the code. I don't THINK we are including the mysql-connector in the
releases, are we?

Summers Pittman

Phone:404 941 4698
Java is my crack.

On Mon, Aug 11, 2014 at 10:02 AM, Matthias Wessendorf <
[email protected]> wrote:

cool

regarding the mysql. the doc uses mysql-connector-java-5.1.18.jar

On Mon, Aug 11, 2014 at 4:00 PM, Hoyt Summers Pittman <
[email protected]> wrote:

@matzew https://github.com/matzew Ok, java 7 things build etc.
[image:
👍] Like I said before your changes actually work. Though on
wildfly
8.0.0 there is a bug with mysql's connector jar on version 30+ which
is
fixed in 8.1.0.

—
Reply to this email directly or view it on GitHub
<

https://github.com/aerogear/aerogear-unifiedpush-server/pull/349#issuecomment-51783545>

.

Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf

—

Reply to this email directly or view it on GitHub
<

https://github.com/aerogear/aerogear-unifiedpush-server/pull/349#issuecomment-51783798>

.

—
Reply to this email directly or view it on GitHub
<
https://github.com/aerogear/aerogear-unifiedpush-server/pull/349#issuecomment-51786143>

.

Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf

—
Reply to this email directly or view it on GitHub
#349 (comment)
.

matzew · 2014-08-11T15:09:40Z

http://staging.aerogear.org/docs/unifiedpush/ups_userguide/server-installation/#_mysql_database_configuration

search for "mvn dependency:copy"

On Mon, Aug 11, 2014 at 5:07 PM, Hoyt Summers Pittman <
[email protected]> wrote:

Can you link me the doc that references the jar version?
On Aug 11, 2014 10:27 AM, "Matthias Wessendorf" [email protected]

wrote:

nope - we are not shipping the mysql jar

On Mon, Aug 11, 2014 at 4:20 PM, Hoyt Summers Pittman <
[email protected]> wrote:

I didn't see a version mentioned in the docs. I only saw it mentioned
in
the code. I don't THINK we are including the mysql-connector in the
releases, are we?

Summers Pittman

Phone:404 941 4698
Java is my crack.

On Mon, Aug 11, 2014 at 10:02 AM, Matthias Wessendorf <
[email protected]> wrote:

cool

regarding the mysql. the doc uses mysql-connector-java-5.1.18.jar

On Mon, Aug 11, 2014 at 4:00 PM, Hoyt Summers Pittman <
[email protected]> wrote:

@matzew https://github.com/matzew Ok, java 7 things build etc.
[image:
👍] Like I said before your changes actually work. Though on
wildfly
8.0.0 there is a bug with mysql's connector jar on version 30+
which
is
fixed in 8.1.0.

—
Reply to this email directly or view it on GitHub
<

https://github.com/aerogear/aerogear-unifiedpush-server/pull/349#issuecomment-51783545>

.

Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf

—

Reply to this email directly or view it on GitHub
<

https://github.com/aerogear/aerogear-unifiedpush-server/pull/349#issuecomment-51783798>

.

—
Reply to this email directly or view it on GitHub
<

https://github.com/aerogear/aerogear-unifiedpush-server/pull/349#issuecomment-51786143>

.

Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf

—
Reply to this email directly or view it on GitHub
<
https://github.com/aerogear/aerogear-unifiedpush-server/pull/349#issuecomment-51787064>

.

—
Reply to this email directly or view it on GitHub
#349 (comment)
.

Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf

danielpassos · 2014-08-11T15:56:19Z

👍 works locally

danbev · 2014-08-12T09:13:57Z

👍 Tested the cli script for WildFly and it works

matzew · 2014-08-12T10:05:01Z

landed in de4def5

matzew added 2 commits August 8, 2014 21:28

Fixing incorrect comments and DS names

ba211e1

Adding URL escaping to wildflyscript

9d99b9b

matzew merged commit 9d99b9b into master Aug 12, 2014

matzew deleted the datasource-cli-fixes branch August 12, 2014 10:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixing incorrect comments and DS names #349

Fixing incorrect comments and DS names #349

matzew commented Aug 8, 2014

matzew commented Aug 8, 2014

secondsun commented Aug 8, 2014

matzew commented Aug 8, 2014

abstractj commented Aug 11, 2014

secondsun commented Aug 11, 2014

matzew commented Aug 11, 2014

secondsun commented Aug 11, 2014

matzew commented Aug 11, 2014

secondsun commented Aug 11, 2014

matzew commented Aug 11, 2014

danielpassos commented Aug 11, 2014

danbev commented Aug 12, 2014

matzew commented Aug 12, 2014

Fixing incorrect comments and DS names #349

Fixing incorrect comments and DS names #349

Conversation

matzew commented Aug 8, 2014

matzew commented Aug 8, 2014

secondsun commented Aug 8, 2014

matzew commented Aug 8, 2014

abstractj commented Aug 11, 2014

secondsun commented Aug 11, 2014

matzew commented Aug 11, 2014

secondsun commented Aug 11, 2014

matzew commented Aug 11, 2014

secondsun commented Aug 11, 2014

matzew commented Aug 11, 2014

danielpassos commented Aug 11, 2014

danbev commented Aug 12, 2014

matzew commented Aug 12, 2014