-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple nodes #69
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithub.com:aerosense-ai/data-gateway into dependencies/remove-unnecessary-dependencies
…pdates Multi node gateway updates
cortadocodes
changed the title
Add multiple node support
Support sensor data from multiple nodes
Jul 7, 2022
cortadocodes
changed the title
Support sensor data from multiple nodes
Support multiple nodes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade
data-gateway
to handle data from multiple nodes instead of one. This pull request pulls together the changes from the following pull requests - view each one for their individual release notes:Breaking changes and changes separate from these PRs are listed below.
Contents (#69)
IMPORTANT: There are 2 breaking changes.
New features
Operations
cloudbuild.yaml
fileRefactoring
Upgrade instructions
💥 Remove incorrectly parameterised default sensor name
MICROPHONE_SENSOR_NAME
is no longer exportedThis was removed because it was a misnomer (actually should have been called
DEFAULT_MICROPHONE_SENSOR_NAME
).It's very unlikely this will cause any onward breaking changes, but if using that variable externally, the user should instead access
data_gateway.configuration.DEFAULT_SENSOR_NAMES[0]
which is the same thing.💥 Update configuration for multiple nodes per #64
Configuration values nested and separated by concerns.
Users should consult docs for the new configuration format. Older
configuration.json
files will no longer work so need to be updated.Periods are now calculated rather than being configurable, to eliminate duplication. Users should
configure the relevant frequency parameters for the sensors.
The
session_data
key was converted tosession
The ambiguous
hardware_version
key was removed and replaced with gateway.receiver_firmware_versionand
nodes[node_id].node_firmware_version`The
packet_key
is no longer present, instead useConfiguration().get_packet_key(node_id)