Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple nodes #69

Merged
merged 189 commits into from
Jul 7, 2022
Merged

Support multiple nodes #69

merged 189 commits into from
Jul 7, 2022

Conversation

cortadocodes
Copy link
Member

@cortadocodes cortadocodes commented Jun 10, 2022

Summary

Upgrade data-gateway to handle data from multiple nodes instead of one. This pull request pulls together the changes from the following pull requests - view each one for their individual release notes:

Breaking changes and changes separate from these PRs are listed below.

Contents (#69)

IMPORTANT: There are 2 breaking changes.

New features

  • 💥 BREAKING CHANGE: Update configuration for multiple nodes (see #64)

Operations

  • Prevent serialisation error in window handler debugging statement
  • Make workflows apply correct memory
  • Remove old cloudbuild.yaml file

Refactoring

  • 💥 BREAKING CHANGE: Remove incorrectly parameterised default sensor name

Upgrade instructions

💥 Remove incorrectly parameterised default sensor name

MICROPHONE_SENSOR_NAME is no longer exported

This was removed because it was a misnomer (actually should have been called DEFAULT_MICROPHONE_SENSOR_NAME).

It's very unlikely this will cause any onward breaking changes, but if using that variable externally, the user should instead access data_gateway.configuration.DEFAULT_SENSOR_NAMES[0] which is the same thing.

💥 Update configuration for multiple nodes per #64

Configuration values nested and separated by concerns.

  • Users should consult docs for the new configuration format. Older configuration.json files will no longer work so need to be updated.

  • Periods are now calculated rather than being configurable, to eliminate duplication. Users should
    configure the relevant frequency parameters for the sensors.

  • The session_data key was converted to session

  • The ambiguous hardware_version key was removed and replaced with gateway.receiver_firmware_versionandnodes[node_id].node_firmware_version`

  • The packet_key is no longer present, instead use Configuration().get_packet_key(node_id)

cortadocodes and others added 30 commits June 8, 2022 11:24
…ithub.com:aerosense-ai/data-gateway into dependencies/remove-unnecessary-dependencies
@cortadocodes cortadocodes marked this pull request as ready for review July 7, 2022 14:04
@cortadocodes cortadocodes changed the title Add multiple node support Support sensor data from multiple nodes Jul 7, 2022
@cortadocodes cortadocodes changed the title Support sensor data from multiple nodes Support multiple nodes Jul 7, 2022
@cortadocodes cortadocodes merged commit cad3583 into main Jul 7, 2022
@cortadocodes cortadocodes deleted the feature/multiple-node-support branch July 7, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants