Tools 2679 show stop writes bug #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
October 4, 2023 15:13
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #210 +/- ##
==========================================
- Coverage 68.71% 68.69% -0.03%
==========================================
Files 91 91
Lines 21222 21230 +8
==========================================
+ Hits 14583 14584 +1
- Misses 6639 6646 +7
☔ View full report in Codecov by Sentry. |
dwelch-spike
requested changes
Oct 6, 2023
jdogmcsteezy
pushed a commit
that referenced
this pull request
Oct 9, 2023
* fix: TOOLS-2679 show stop-writes does not report storage-engine device or pmem metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed
device_available_pcttodevice_avail_pctand renamed the threshold metrics to includestorage-engine.The 7.0 metrics are included as well, but that is ok. There is a slight refactor in some other places around grabbing metrics from dicts.