Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOOLS-2669 TOOLS-2683 TOOLS-2705 TOOLS-2706 7.0 config/stats changes #218

Merged
merged 16 commits into from
Oct 19, 2023

Conversation

jdogmcsteezy
Copy link

This PR includes:

  • A redesign of the info namespace usage table to incorporate new storage-engine.memory design
  • Updates to summary to incorporate new storage-engine.memory design
  • An update to all healthchecks that use removed/renamed stats and configs
  • Updates to the unique data usage calculation

@jdogmcsteezy jdogmcsteezy force-pushed the TOOLS-2669-7.0-changes branch from a7794b8 to c0cbd68 Compare October 18, 2023 20:11
@codecov-commenter
Copy link

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (e840e29) 68.75% compared to head (15df2e9) 69.43%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
+ Coverage   68.75%   69.43%   +0.68%     
==========================================
  Files          91       91              
  Lines       21266    21298      +32     
==========================================
+ Hits        14621    14788     +167     
+ Misses       6645     6510     -135     
Files Coverage Δ
lib/collectinfo_analyzer/info_controller.py 62.59% <100.00%> (+0.28%) ⬆️
lib/health/query.py 100.00% <ø> (ø)
lib/live_cluster/info_controller.py 83.49% <100.00%> (+0.16%) ⬆️
lib/live_cluster/show_controller.py 97.85% <ø> (ø)
lib/view/templates.py 87.82% <100.00%> (+0.55%) ⬆️
lib/utils/common.py 73.59% <99.33%> (+3.80%) ⬆️
lib/view/view.py 65.25% <91.80%> (+8.08%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dwelch-spike dwelch-spike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdogmcsteezy jdogmcsteezy changed the title Tools 2669 7.0 config/stats changes TOOLS-2669 TOOLS-2683 TOOLS-2705 TOOLS-2706 7.0 config/stats changes Oct 19, 2023
@jdogmcsteezy jdogmcsteezy merged commit 2130398 into master Oct 19, 2023
@jdogmcsteezy jdogmcsteezy deleted the TOOLS-2669-7.0-changes branch October 19, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants