Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: TOOLS-2995 a generate config output to collectinfo archive #223

Merged
merged 4 commits into from
Nov 10, 2023

Conversation

jdogmcsteezy
Copy link

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (b9e687e) 68.75% compared to head (5340a9a) 70.08%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
+ Coverage   68.75%   70.08%   +1.32%     
==========================================
  Files          91       91              
  Lines       21266    21315      +49     
==========================================
+ Hits        14621    14938     +317     
+ Misses       6645     6377     -268     
Files Coverage Δ
lib/collectinfo_analyzer/info_controller.py 62.59% <100.00%> (+0.28%) ⬆️
lib/health/query.py 100.00% <ø> (ø)
lib/live_cluster/client/cluster.py 76.48% <100.00%> (+0.05%) ⬆️
lib/live_cluster/info_controller.py 83.49% <100.00%> (+0.16%) ⬆️
lib/live_cluster/show_controller.py 97.85% <ø> (ø)
lib/view/templates.py 87.82% <100.00%> (+0.55%) ⬆️
lib/utils/common.py 73.59% <99.33%> (+3.80%) ⬆️
lib/live_cluster/collectinfo_controller.py 76.51% <87.50%> (+0.57%) ⬆️
lib/view/view.py 65.25% <91.80%> (+8.08%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dwelch-spike dwelch-spike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdogmcsteezy jdogmcsteezy merged commit 8144fb8 into master Nov 10, 2023
4 checks passed
@jdogmcsteezy jdogmcsteezy deleted the TOOLS-2695-add-gen-conf-to-collectinfo branch November 10, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants