Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPS-1367 Add support for backup retention configuration #287

Merged
merged 28 commits into from
Dec 23, 2024

Conversation

korotkov-aerospike
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2024

Codecov Report

Attention: Patch coverage is 81.03448% with 22 lines in your changes missing coverage. Please review.

Project coverage is 44.57%. Comparing base (26598d7) to head (d559193).

Files with missing lines Patch % Lines
pkg/service/retention_manager.go 73.91% 12 Missing and 6 partials ⚠️
pkg/dto/backup_policy.go 94.44% 1 Missing and 1 partial ⚠️
pkg/service/cluster_config_writer.go 0.00% 1 Missing ⚠️
pkg/service/paths.go 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v2     #287      +/-   ##
==========================================
+ Coverage   42.92%   44.57%   +1.64%     
==========================================
  Files          50       51       +1     
  Lines        2721     2809      +88     
==========================================
+ Hits         1168     1252      +84     
+ Misses       1433     1432       -1     
- Partials      120      125       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@korotkov-aerospike korotkov-aerospike changed the title APPS-1367 Retention APPS-1367 Backup retention Dec 23, 2024
@korotkov-aerospike korotkov-aerospike marked this pull request as ready for review December 23, 2024 08:03
@reugn reugn changed the title APPS-1367 Backup retention APPS-1367 Add support for backup retention configuration Dec 23, 2024
pkg/dto/backup_policy.go Show resolved Hide resolved
pkg/dto/backup_policy.go Outdated Show resolved Hide resolved
pkg/dto/backup_policy.go Outdated Show resolved Hide resolved
pkg/service/retention_manager.go Outdated Show resolved Hide resolved
pkg/service/retention_manager.go Outdated Show resolved Hide resolved
pkg/service/retention_manager.go Show resolved Hide resolved
@korotkov-aerospike korotkov-aerospike merged commit ae82738 into v2 Dec 23, 2024
7 checks passed
@korotkov-aerospike korotkov-aerospike deleted the retention branch December 23, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants