Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPS-1431 Synchronize access to the service configuration #295

Merged
merged 18 commits into from
Jan 1, 2025

Conversation

korotkov-aerospike
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 20 lines in your changes missing coverage. Please review.

Project coverage is 44.01%. Comparing base (8f2781f) to head (80da7c6).
Report is 1 commits behind head on v3.

Files with missing lines Patch % Lines
pkg/dto/backup_details.go 0.00% 8 Missing ⚠️
pkg/service/config_applier.go 0.00% 7 Missing ⚠️
pkg/service/aerospike/namespace_validator.go 0.00% 3 Missing ⚠️
pkg/dto/base_dto.go 0.00% 1 Missing ⚠️
pkg/dto/restore_request.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v3     #295      +/-   ##
==========================================
+ Coverage   43.92%   44.01%   +0.09%     
==========================================
  Files          52       52              
  Lines        2857     2851       -6     
==========================================
  Hits         1255     1255              
+ Misses       1476     1470       -6     
  Partials      126      126              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@korotkov-aerospike
Copy link
Contributor Author

  1. moved lock from config to service level.
  2. reduced number of pointers to config. Actually, now after initial startup, it is only stored in http service. So, every request to config goes through http service.
    Periodic backups dont access config.

pkg/model/config.go Outdated Show resolved Hide resolved
pkg/model/config.go Outdated Show resolved Hide resolved
pkg/model/config.go Outdated Show resolved Hide resolved
@reugn reugn changed the title APPS-1431 Thread safe config APPS-1431 Synchronize access to the service configuration Dec 30, 2024
@korotkov-aerospike korotkov-aerospike marked this pull request as ready for review December 30, 2024 15:22
@korotkov-aerospike korotkov-aerospike merged commit 71e33b4 into v3 Jan 1, 2025
7 checks passed
@korotkov-aerospike korotkov-aerospike deleted the thread_safe_config branch January 1, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants