Documentaiton changes, fix force single node

.github/actions/run-ee-server/action.yml

@@ -42,7 +42,7 @@ runs:
   - name: Build and push
     uses: docker/build-push-action@v6
     with:
-      # Don't want to use default Git context or else it will clone the whole Python client repo again
+      # Don't want to use default Git context or else it will clone the whole client repo again
       context: .github/workflows/docker-build-context
       build-args: |
         server_image=${{ env.IMAGE_NAME }}

.github/workflows/tests.yml

@@ -24,32 +24,6 @@ on:
         required: true
 
 jobs:
-  #build:
-  #  runs-on: ubuntu-latest
-  #  strategy:
-  #    fail-fast: false
-  #
-  #  steps:
-  #  - uses: actions/checkout@v4
-  #  - name: Setup .NET
-  #    uses: actions/setup-dotnet@v4
-  #    with:
-  #      dotnet-version: 6.0.x
-  #  - name: Restore dependencies
-  #    run: dotnet restore /p:EnableWindowsTargeting=true
-  #  #- name: Install dependencies
-  #  #  run: dotnet add package NeoLua --version 1.3.14
-  #  - name: Build
-  #    run: dotnet build --configuration Release --no-restore /p:EnableWindowsTargeting=true
-  #   
-  #  - name: Publish
-  #    run: dotnet publish -c Release -o ../publish
-  #    
-  #  - name: Send files to test jobs
-  #    uses: actions/upload-artifact@v3
-  #    with:
-  #      name: AerospikeClient.dll
-  #      path: ./AerospikeClient/bin/Debug/*.whl
 
   test-ee:
     runs-on: ubuntu-latest
@@ -61,14 +35,15 @@ jobs:
         use-server-rc: true
         docker-hub-username: ${{ secrets.DOCKER_HUB_BOT_USERNAME }}
         docker-hub-password: ${{ secrets.DOCKER_HUB_BOT_PW }}
+
     - name: Setup .NET
       uses: actions/setup-dotnet@v4
       with:
         dotnet-version: 6.0.x
+
     - name: Restore dependencies
       run: dotnet restore /p:EnableWindowsTargeting=true
-    #- name: Install dependencies
-    #  run: dotnet add package NeoLua --version 1.3.14
+
     - name: Build
       run: dotnet build --configuration Release --no-restore /p:EnableWindowsTargeting=true
 

AerospikeClient/Admin/Role.cs

@@ -1,5 +1,5 @@
 /* 
- * Copyright 2012-2022 Aerospike, Inc.
+ * Copyright 2012-2024 Aerospike, Inc.
  *
  * Portions may be licensed to Aerospike, Inc. under one or more contributor
  * license agreements.

AerospikeClient/Async/AsyncClient.cs

@@ -134,6 +134,19 @@ public AsyncClient(AsyncClientPolicy policy, params Host[] hosts)
 		// Multi-Record Transactions
 		//-------------------------------------------------------
 
+		/// <summary>
+		/// Asynchronously attempt to commit the given multi-record transaction.
+		/// Create listener, call asynchronous commit and return task monitor.
+		/// </summary>
+		/// <param name="txn">multi-record transaction</param>
+		/// <param name="token">cancellation token</param>
+		public Task Commit(Txn txn, CancellationToken token)
+		{
+			var listener = new CommitListenerAdapter(token);
+			Commit(listener, txn);
+			return listener.Task;
+		}
+
 		/// <summary>
 		/// Asynchronously attempt to commit the given multi-record transaction. First, the expected
 		/// record versions are sent to the server nodes for verification. If all nodes return success,
@@ -177,22 +190,23 @@ public void Commit(CommitListener listener, Txn txn)
 		}
 
 		/// <summary>
-		/// Asynchronously attempt to commit the given multi-record transaction.
-		/// Create listener, call asynchronous put and return task monitor.
+		/// Asynchronously attempt to abort and rollback the given multi-record transaction.
+		/// Create listener, call asynchronous commit and return task monitor.
 		/// </summary>
 		/// <param name="txn">multi-record transaction</param>
 		/// <param name="token">cancellation token</param>
-		public Task Commit(Txn txn, CancellationToken token)
+		public Task Abort(Txn txn, CancellationToken token)
 		{
-			var listener = new CommitListenerAdapter(token);
-			Commit(listener, txn);
+			var listener = new AbortListenerAdapter(token);
+			Abort(listener, txn);
 			return listener.Task;
 		}
 
+
 		/// <summary>
 		/// Asynchronously abort and rollback the given multi-record transaction.
 		/// <para>
-		/// Schedules the commit command with a channel selector and return.
+		/// Schedules the abort command with a channel selector and return.
 		/// Another thread will process the command and send the results to the listener.
 		/// </para><para>
 		/// Requires server version 8.0+
@@ -222,13 +236,6 @@ public void Abort(AbortListener listener, Txn txn)
 			}
 		}
 
-		public Task Abort(Txn txn, CancellationToken token)
-		{
-			var listener = new AbortListenerAdapter(token);
-			Abort(listener, txn);
-			return listener.Task;
-		}
-
 		//-------------------------------------------------------
 		// Write Record Operations
 		//-------------------------------------------------------

AerospikeClient/Async/AsyncQueryPartitionExecutor.cs

@@ -14,8 +14,6 @@
  * License for the specific language governing permissions and limitations under
  * the License.
  */
-using System;
-using System.Collections.Generic;
 
 namespace Aerospike.Client
 {

AerospikeClient/Async/AsyncScanPartitionExecutor.cs

@@ -14,8 +14,6 @@
  * License for the specific language governing permissions and limitations under
  * the License.
  */
-using System;
-using System.Collections.Generic;
 
 namespace Aerospike.Client
 {

AerospikeClient/Async/IAsyncClient.cs

@@ -1,5 +1,5 @@
 /* 
- * Copyright 2012-2022 Aerospike, Inc.
+ * Copyright 2012-2024 Aerospike, Inc.
  *
  * Portions may be licensed to Aerospike, Inc. under one or more contributor
  * license agreements.
@@ -41,32 +41,49 @@ public interface IAsyncClient : IAerospikeClient
 		// Multi-Record Transactions
 		//-------------------------------------------------------
 
+		/// <summary>
+		/// Asynchronously attempt to commit the given multi-record transaction.
+		/// Create listener, call asynchronous commit and return task monitor.
+		/// </summary>
+		/// <param name="txn">multi-record transaction</param>
+		/// <param name="token">cancellation token</param>
+		public Task Commit(Txn txn, CancellationToken token);
+
 		/// <summary>
 		/// Asynchronously attempt to commit the given multi-record transaction. First, the expected
-		/// record versions are sent to the server nodes for verification.If all nodes return success,
+		/// record versions are sent to the server nodes for verification. If all nodes return success,
 		/// the transaction is committed. Otherwise, the transaction is aborted.
 		/// <para>
-		/// This method registers the command with an event loop and returns.
-		/// The event loop thread will process the command and send the results to the listener.
-		/// </para><para>
+		/// Schedules the commit command with a channel selector and return.
+		/// Another thread will process the command and send the results to the listener.
+		/// </para>
+		/// <para>
 		/// Requires server version 8.0+
 		/// </para>
 		/// </summary>
 		/// <param name="listener">where to send results</param>
 		/// <param name="txn">multi-record transaction</param>
 		void Commit(CommitListener listener, Txn txn);
 
+		/// <summary>
+		/// Asynchronously attempt to abort and rollback the given multi-record transaction.
+		/// Create listener, call asynchronous commit and return task monitor.
+		/// </summary>
+		/// <param name="txn">multi-record transaction</param>
+		/// <param name="token">cancellation token</param>
+		public Task Abort(Txn txn, CancellationToken token);
+
 		/// <summary>
 		/// Asynchronously abort and rollback the given multi-record transaction.
 		/// <para>
-		/// This method registers the command with an event loop and returns.
-		/// The event loop thread will process the command and send the results to the listener.
+		/// Schedules the abort command with a channel selector and return.
+		/// Another thread will process the command and send the results to the listener.
 		/// </para><para>
 		/// Requires server version 8.0+
 		/// </para>
 		/// </summary>
-		/// <param name="listener"></param>
-		/// <param name="txn"></param>
+		/// <param name="listener">where to send results</param>
+		/// <param name="txn">multi-record transaction</param>
 		void Abort(AbortListener listener, Txn txn);
 
 		//-------------------------------------------------------

AerospikeClient/Cluster/NodeValidator.cs

@@ -100,6 +100,11 @@ public Node SeedNode(Cluster cluster, Host host, Peers peers)
 
 		private bool ValidatePeers(Peers peers, Node node)
 		{
+			if (peers == null)
+			{
+				return true;
+			}
+
 			try
 			{
 				peers.refreshCount = 0;

AerospikeClient/Command/Batch.cs

@@ -536,7 +536,7 @@ protected internal override bool ParseRow()
 
 			BatchRecord record = records[batchIndex];
 
-			if (resultCode == 0)
+			if (resultCode == ResultCode.OK)
 			{
 				record.resultCode = resultCode;
 			}

AerospikeClient/Command/Command.cs

@@ -316,7 +316,7 @@ public void SetTxnMarkRollForward(Key key)
 			Begin();
 			int fieldCount = EstimateKeySize(key);
 			EstimateOperationSize(bin);
-			SizeBuffer();
+			//SizeBuffer();
 			WriteTxnMonitor(key, 0, Command.INFO2_WRITE, fieldCount, 1);
 			WriteOperation(bin, Operation.Type.WRITE);
 			End();
@@ -462,14 +462,15 @@ public void SetTxnClose(Txn txn, Key key)
 		{
 			Begin();
 			int fieldCount = EstimateKeySize(key);
-			SizeBuffer();
+			//SizeBuffer();
 			WriteTxnMonitor(key, 0, Command.INFO2_WRITE | Command.INFO2_DELETE | Command.INFO2_DURABLE_DELETE,
 				fieldCount, 0);
 			End();
 		}
 
 		private void WriteTxnMonitor(Key key, int readAttr, int writeAttr, int fieldCount, int opCount)
 		{
+			SizeBuffer();
 			dataOffset += 8;
 			dataBuffer[dataOffset++] = MSG_REMAINING_HEADER_SIZE;
 			dataBuffer[dataOffset++] = (byte)readAttr;

AerospikeClient/Command/ExecuteCommand.cs

@@ -24,7 +24,7 @@ public sealed class ExecuteCommand : SyncWriteCommand
 		private readonly string packageName;
 		private readonly string functionName;
 		private readonly Value[] args;
-		public Record Record {  get; private set; }
+		public Record Record { get; private set; }
 
 		public ExecuteCommand
 		(

AerospikeClient/Command/OperateArgs.cs

@@ -1,5 +1,5 @@
 /* 
- * Copyright 2012-2023 Aerospike, Inc.
+ * Copyright 2012-2024 Aerospike, Inc.
  *
  * Portions may be licensed to Aerospike, Inc. under one or more contributor
  * license agreements.

AerospikeClient/Command/ReadCommand.cs

@@ -53,6 +53,7 @@ protected internal override void ParseResult(Connection conn)
 		{
 			ParseHeader(conn);
 			ParseFields(policy.Txn, key, false);
+
 			if (resultCode == ResultCode.OK)
 			{
 				this.record = policy.recordParser.ParseRecord(dataBuffer, ref dataOffset, opCount, generation, expiration, isOperation);

AerospikeClient/Listener/CommitListener.cs

@@ -24,7 +24,7 @@ namespace Aerospike.Client
 	public interface CommitListener
 	{
 		/// <summary>
-		/// This method is called when the records are verified and the commit succeeds.
+		/// This method is called when the records are verified and the commit succeeded or will succeed.
 		/// </summary>
 		void OnSuccess(CommitStatusType status);