Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking the emptiness of binNames field before setting into command #321

Closed
wants to merge 1 commit into from

Conversation

abhilashmandaliya
Copy link
Member

  • Added check for binNames of all Command to avoid Parameter error when passing an empty array
    • JVM languages like Kotlin treat null and non-null explicitly. To invoke a constructor version of commands that sets the binNames to null, requires a separate if-else code block from the caller site to invoke a desired version of the constructor and, makes code unnecessarily lengthy. However, we can pass an empty array from Kotlin and keep the code cleaner. In the current implementation, it causes a Parameter error.
  • Applied minor IDE suggestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants