Skip to content

Commit

Permalink
test fix
Browse files Browse the repository at this point in the history
  • Loading branch information
DomPeliniAerospike committed Oct 21, 2024
1 parent 447a241 commit 6931477
Show file tree
Hide file tree
Showing 5 changed files with 1,584 additions and 26 deletions.
8 changes: 1 addition & 7 deletions .github/assets/aerospike.conf
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,7 @@ network {
port 3001
}
}
namespace avs-meta {
allow-ttl-without-nsup true
replication-factor 2
storage-engine memory {
data-size 2G
}
}

namespace test {
allow-ttl-without-nsup true
replication-factor 2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ jobs:

- name: Run Aerospike server
if: ${{ !contains(github.event.pull_request.labels.*.name, 'new-server-features') }}
run: docker run -d --name aerospike -p 3000-3002:3000-3002 aerospike/aerospike-server:7.1
run: docker run -d -v .github/assets:/opt/aerospike/etc--name aerospike -p 3000-3002:3000-3002 --config-file /opt/aerospike/etc/aerospike.conf aerospike/aerospike-server:7.1

- name: Wait for database to be ready
# Should be ready after 3 seconds
Expand Down
2 changes: 0 additions & 2 deletions lib/exp_operations.js
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,6 @@ exports.read = function (bin, exp, flags) {
* @summary Update the value of the bin.
*
* @param {string} bin - The name of the bin.
* @param {any} value - The value to set the bin to.
* @param {string} binName - The variable name of read expression result. This name can be used as the bin name when retrieving bin results from the record.
* @param {AerospikeExp} exp - The expression to evaluate
* @param flags - Expression write flags. <code>flags</code> must be an integer. See {@link exp.expWriteFlags} for more information.
* @returns {Operation} Operation that can be passed to the {@link Client#operate} command.
Expand Down
2 changes: 1 addition & 1 deletion ts-test/tests/exists.ts
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ describe('client.existsWithMetadata()', function () {
it('returns an Aerospike Record with Metatdata if the record exists and no meta or ttl is set', function () {
const key: Key = keygen.string(helper.namespace, helper.set, { prefix: 'test/exists/6' })()

return client.put(key, { str: 'abcde' })
return client.put(key, { str: 'abcde' }, {ttl: -1})
.then(() => client.existsWithMetadata(key))
.then(result => {
expect(result.key).to.eql(key)
Expand Down
Loading

0 comments on commit 6931477

Please sign in to comment.