Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Version information #583

Merged
merged 10 commits into from
Sep 28, 2023
Merged

Updated Version information #583

merged 10 commits into from
Sep 28, 2023

Conversation

DomPeliniAerospike
Copy link
Collaborator

Fixed AerospikeError Api documentation
Modifiied README.md
Modified incompatible.md
Updated Version information
Modified preBuiltBinding.js

Fixed AerospikeError Api documentation
Modifiied README.md
Modified incompatible.md
Updated Version information
Modified preBuiltBinding.js
Fixed variable issue
Updated install script for windows compatibility.
Updated typings.
installed npm-run-all package
Ran npm update and npm update -D
Renamed prebuild to removeExtraBinaries
Removed npm-run-all for npm run
Added correct build script
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (949c658) 89.86% compared to head (c1a599a) 91.25%.
Report is 13 commits behind head on stage.

❗ Current head c1a599a differs from pull request most recent head c595140. Consider uploading reports for the commit c595140 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #583      +/-   ##
==========================================
+ Coverage   89.86%   91.25%   +1.38%     
==========================================
  Files          68       69       +1     
  Lines        2221     2229       +8     
==========================================
+ Hits         1996     2034      +38     
+ Misses        225      195      -30     
Files Coverage Δ
lib/aerospike.js 97.33% <100.00%> (+0.03%) ⬆️
lib/error.js 97.14% <ø> (ø)
lib/exp.js 100.00% <100.00%> (ø)
lib/exp_lists.js 89.09% <100.00%> (+21.81%) ⬆️
lib/exp_maps.js 82.53% <100.00%> (+30.15%) ⬆️
lib/bin.js 80.00% <80.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mcoberly2 mcoberly2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcoberly2 mcoberly2 merged commit 2c5f49e into stage Sep 28, 2023
6 checks passed
@mcoberly2 mcoberly2 deleted the Nodejs-Release-5.8.0 branch September 28, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants