Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodejs pre release 5.9.0 #591

Merged
merged 34 commits into from
Nov 7, 2023
Merged

Conversation

DomPeliniAerospike
Copy link
Collaborator

No description provided.

mcoberly2 and others added 16 commits September 28, 2023 15:58
CLIENT-2629
Added logic to ignore AEROSPIKE_BATCH_FAILED in cases where records are returned for all batch commands
Fixed AEROSPIKE_BATCH_FAILED error issue
CLIENT-2592
Added exp.expWriteFlags and exp.expReadFlags
Added exp.expWriteFlags and exp.expReadFlags
CLIENT-2587
Added Blob Secondary index support
Added client.createBlobIndex
Fixed Javascript Maps to place non-string indexes on server
Added Bolb Secondary Index support.
CLIENT-2617
Added maps.create method
Added persitIndex as a parameter
use "npm run lint"
Added additional logic to batchRemove test to clean records in which batchRemove failed
CLIENT-1421
Added maxErrorRate and errorRateWindow configurations.
Fixed bug with tenderInteval
Added maxErrorRate and errorRateWindow configurations
Added/modified Client examples for batch, maps.create,  expression operations.
Added context as a parameter to maps.create.
Modified testing config to set max_error_rate = 0
Modifed testing to omit 7.0 features when server is a lower version.
Added documentation.
Removed unnecessary memory allocation and print statements in query.cc
Disabled blob sindex testing on server versions less than 7.0
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (c1a599a) 91.25% compared to head (fdd06e4) 91.55%.
Report is 1 commits behind head on stage.

❗ Current head fdd06e4 differs from pull request most recent head 9931d67. Consider uploading reports for the commit 9931d67 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #591      +/-   ##
==========================================
+ Coverage   91.25%   91.55%   +0.30%     
==========================================
  Files          69       69              
  Lines        2229     2250      +21     
==========================================
+ Hits         2034     2060      +26     
+ Misses        195      190       -5     
Files Coverage Δ
lib/config.js 92.45% <100.00%> (+0.61%) ⬆️
lib/exp.js 100.00% <100.00%> (ø)
lib/exp_operations.js 92.30% <ø> (ø)
lib/maps.js 100.00% <100.00%> (ø)
lib/filter.js 98.03% <50.00%> (-1.97%) ⬇️
lib/client.js 81.15% <71.42%> (-0.14%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

realmgic
realmgic previously approved these changes Nov 6, 2023
lib/client.js Outdated
*
* // INSERT HOSTNAME AND PORT NUMBER OF AEROSPIKE SERVER NODE HERE!
* // INSERT HOSTNAME AND PORT NUMBER OF AEROPSIKE SERVER NODE HERE!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling

artanderson
artanderson previously approved these changes Nov 7, 2023
Ran npm audit fix.
Removed Dockerfiles
Added README.md to docker folder explaining where files went.
@DomPeliniAerospike DomPeliniAerospike merged commit 7f89eec into stage Nov 7, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants