Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLIENT-2749 #599

Merged
merged 9 commits into from
Jan 16, 2024
Merged

CLIENT-2749 #599

merged 9 commits into from
Jan 16, 2024

Conversation

DomPeliniAerospike
Copy link
Collaborator

No description provided.

CLIENT-2672
CLIENT-2709
CLIENT-2749
CLIENT-2750
Changed npm-run-all from a dev-dependency to a dependency.
Added missing BOOL enumeration to Aerospike.exp.type. In scan/query with maxRecords set, mark node's partitions for retry on next scan/query page when that node returns records that are discarded due to exceeding maxRecords.
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fdd06e4) 91.55% compared to head (7d6cd4c) 91.68%.
Report is 1 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #599      +/-   ##
==========================================
+ Coverage   91.55%   91.68%   +0.13%     
==========================================
  Files          69       69              
  Lines        2250     2250              
==========================================
+ Hits         2060     2063       +3     
+ Misses        190      187       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CLIENT-2751
Added support for Node.js 21.
mcoberly2
mcoberly2 previously approved these changes Jan 13, 2024
Copy link
Contributor

@mcoberly2 mcoberly2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW LGTM, other than one suggested change.

README_WINDOWS.md Outdated Show resolved Hide resolved
mcoberly2
mcoberly2 previously approved these changes Jan 13, 2024
mcoberly2
mcoberly2 previously approved these changes Jan 13, 2024
mcoberly2
mcoberly2 previously approved these changes Jan 13, 2024
Copy link
Contributor

@mcoberly2 mcoberly2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, LGTM

@DomPeliniAerospike DomPeliniAerospike merged commit 417856f into stage Jan 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants