Added on-demand backup check

api/v1beta1/aerospikebackup_webhook.go

@@ -249,6 +249,11 @@ func (r *AerospikeBackup) validateAerospikeCluster(backupSvcConfig *model.Config
 }
 
 func (r *AerospikeBackup) validateOnDemandBackupsUpdate(oldObj *AerospikeBackup) error {
+	if !reflect.DeepEqual(r.Spec.OnDemandBackups, r.Status.OnDemandBackups) &&
+		!reflect.DeepEqual(r.Spec.Config.Raw, r.Status.Config.Raw) {
+		return fmt.Errorf("can not add/update onDemand backup along with backup config change")
+	}
+
 	if len(r.Spec.OnDemandBackups) > 0 && len(oldObj.Spec.OnDemandBackups) > 0 {
 		// Check if onDemand backup spec is updated
 		if r.Spec.OnDemandBackups[0].ID == oldObj.Spec.OnDemandBackups[0].ID &&

test/backup/backup_test.go

@@ -292,6 +292,44 @@ var _ = Describe(
 					Expect(err.Error()).To(ContainSubstring("aerospike-cluster name update is not allowed"))
 				})
 
+				It("Should fail when on-demand backup is added along with backup-config update", func() {
+					backup, err = NewBackup(backupNsNm)
+					Expect(err).ToNot(HaveOccurred())
+
+					err = CreateBackup(k8sClient, backup)
+					Expect(err).ToNot(HaveOccurred())
+
+					err = validateTriggeredBackup(k8sClient, backup)
+					Expect(err).ToNot(HaveOccurred())
+
+					backup, err = getBackupObj(k8sClient, backup.Name, backup.Namespace)
+					Expect(err).ToNot(HaveOccurred())
+
+					backup.Spec.OnDemandBackups = []asdbv1beta1.OnDemandBackupSpec{
+						{
+							ID:          "on-demand",
+							RoutineName: namePrefix(backupNsNm) + "-" + "test-routine",
+						},
+					}
+
+					// change storage to change overall backup config
+					config := getBackupConfigInMap(namePrefix(backupNsNm))
+					backupRoutines := config[common.BackupRoutinesKey].(map[string]interface{})
+					backupRoutines[namePrefix(backupNsNm)+"-"+"test-routine"].(map[string]interface{})[common.StorageKey] =
+						"s3Storage"
+
+					config[common.BackupRoutinesKey] = backupRoutines
+
+					configBytes, mErr := json.Marshal(config)
+					Expect(mErr).ToNot(HaveOccurred())
+
+					backup.Spec.Config.Raw = configBytes
+
+					err = updateBackup(k8sClient, backup)
+					Expect(err).To(HaveOccurred())
+					Expect(err.Error()).To(ContainSubstring(
+						"can not add/update onDemand backup along with backup config change"))
+				})
 			},
 		)