KO-165: Added support for simultaneous scale-down and rolling restart SC cluster #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
abhishekdwivedi3060
commented
Jul 10, 2023
abhishekdwivedi3060
commented
- Added support for simultaneous scale-down and rolling restart SC cluster
tanmayja
reviewed
Sep 14, 2023
controllers/strong_consistency.go
Outdated
| return nil, err | ||
| } | ||
|
|
||
| addSCNamespaces, err := r.addedSCNamespaces(allHostConns) |
There was a problem hiding this comment.
Is it ok to get sc namespaces from all the hosts even if there are some entries in r.aeroCluster.Spec.RosterNodeBlockList? similarly in validateSCClusterState
There was a problem hiding this comment.
As per discussion, not much useful. So skipping extra checks for RosterNodeBlockList
tanmayja
reviewed
Sep 14, 2023
controllers/strong_consistency.go
Outdated
|
|
||
| func (r *SingleClusterReconciler) getIgnorableNamespaces(allHostConns []*deployment.HostConn) ( | ||
| sets.Set[string], error) { | ||
| removedNSes, err := r.removedNamespaces(allHostConns) |
There was a problem hiding this comment.
we call deployment.GetClusterNamespaces in both removedNamespaces as well as r.addedSCNamespaces, see if we can reduce calls here.
sud82
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.