[KO-293] - Adding support for dynamic config change. #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishekdwivedi3060
requested changes
Feb 12, 2024
abhishekdwivedi3060
approved these changes
Mar 27, 2024
sud82
requested changes
Apr 8, 2024
sud82
requested changes
Apr 10, 2024
test/cluster_test.go
Outdated
| namespaceConfig["replication-factor"] = 3 | ||
| aeroCluster.Spec.AerospikeConfig.Value["namespaces"].([]interface{})[len(nsList)-1] = namespaceConfig | ||
|
|
||
| err = k8sClient.Update( |
There was a problem hiding this comment.
Use update with wait. The current call will only check for validation and not actual dynamic setting of rf
api/v1/utils.go
Outdated
| @@ -63,7 +63,7 @@ const ( | |||
| AerospikeInitContainerRegistryEnvVar = "AEROSPIKE_KUBERNETES_INIT_REGISTRY" | |||
| AerospikeInitContainerDefaultRegistry = "docker.io" | |||
| AerospikeInitContainerDefaultRegistryNamespace = "tanmayj10" | |||
| AerospikeInitContainerDefaultRepoAndTag = "aerospike-kubernetes-init:2.1.0-dev1" | |||
| AerospikeInitContainerDefaultRepoAndTag = "aerospike-kubernetes-init:2.1.0-dev3" | |||
There was a problem hiding this comment.
Create a new init tag and use that. Init changes are merged.
abhishekdwivedi3060
approved these changes
Apr 10, 2024
sud82
approved these changes
Apr 10, 2024
tanmayja
changed the title
tanmayja
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to handle aerospike config fields which can be changed dynamically without any rolling restart.
whenever user will change any config in CR, operator will do certain operations:
Compare the spec and status config from CR and fetch different config in a specific format.
Check whether that field is static or dynamic.
If dynamic, construct the set-config command based on the context and sub-context.
Execute the command in all the hosts via asinfo.
If command fails for any reason, fall back to rolling restart.