[KO-290] Allow enabling security in the existing deployed cluster #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishekdwivedi3060
approved these changes
Feb 22, 2024
abhishekdwivedi3060
approved these changes
Feb 27, 2024
sud82
reviewed
Mar 15, 2024
api/v1/aerospikecluster_types.go
Outdated
| @@ -871,6 +871,9 @@ type AerospikePodStatus struct { //nolint:govet // for readability | |||
|
|
|||
| // PodSpecHash is ripemd160 hash of PodSpec used by this pod | |||
| PodSpecHash string `json:"podSpecHash"` | |||
|
|
|||
| // SecurityEnabled is true if security is enabled in the pod | |||
| SecurityEnabled bool `json:"securityEnabled"` | |||
There was a problem hiding this comment.
I think a better name would be IsSecurityEnabled
|
|
||
| enabled, newErr = asdbv1.IsSecurityEnabled( | ||
| incomingVersion, incomingVersionErr := asdbv1.GetImageVersion(desiredState.Image) |
There was a problem hiding this comment.
Shouldn't we check for the enable security from spec by default? If it is not enabled then look into the status.
There was a problem hiding this comment.
The idea here was to send Aerospike credentials if security is enabled in either the spec or status. Following that, we check for AerospikeAccessControl in the status to determine whether to use user-provided credentials or the default admin credentials.
sud82
approved these changes
Mar 19, 2024
abhishekdwivedi3060
requested changes
Mar 19, 2024
abhishekdwivedi3060
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.