K0-314: Added support for batch scale-down #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishekdwivedi3060
force-pushed
the
KO-314
branch
from
5b851a4 to
cb64c60
Compare
abhishekdwivedi3060
force-pushed
the
KO-314
branch
from
2674bb8 to
22dfa83
Compare
tanmayja
reviewed
Apr 10, 2024
controllers/rack.go
Outdated
|
|
||
| podName := getSTSPodName(found.Name, *found.Spec.Replicas-1) | ||
| podsBatchList := r.getPodBatchToScaleDown(oldPodList[:diffPods], len(oldPodList)) |
There was a problem hiding this comment.
can use existing getPodBatchToRestart
tanmayja
reviewed
Apr 10, 2024
controllers/rack.go
Outdated
| @@ -940,7 +960,7 @@ func (r *SingleClusterReconciler) scaleDownRack( | |||
|
|
|||
| // No need for these checks if pod was not running. | |||
There was a problem hiding this comment.
can change comments like pod -> pods etc..
abhishekdwivedi3060
force-pushed
the
KO-314
branch
from
4373ba6 to
7d34e31
Compare
tanmayja
approved these changes
Apr 12, 2024
sud82
requested changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.