Adding negative testcase for dynamic config #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sud82
requested changes
Apr 15, 2024
|
|
||
| case lib.Stats: | ||
|
|
||
| default: |
There was a problem hiding this comment.
Let's remove the nil type. We would know if there is any other type we are missing.
sud82
reviewed
Apr 24, 2024
|
|
||
| // For versions 6.0 and later, replication-factor is dynamic for AP namespaces (non strong-consistency). | ||
| if (IsNSSCEnabled(singleConf) || val < 0) && isValueUpdated( | ||
| // replication-factor update not allowed |
sud82
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: update lib tag after PR-284 merged.