Fixing bugs #287
Merged
Fixing bugs #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tanmayja
commented
May 6, 2024
•
tanmayja
commented
- In case of unavailable partition recovery, scale up the cluster with batch and wait for sts after scale up.
- In case of security enabled flag:
- if status.pods is nil, don't allow security update.
- if isSecurityEnabled(status.aerospikeConfig) is true and spec is false, then don't allow to disable security.
- remove IsSecurityEnabled flag, instead getting security enabled info by comparing hash.
- In case of multiPodPerHost, deref the value and then compare
- Allow EnableDynamicConfigUpdate to be true only if init image is updated to 2.2.0 or above.
- Add IsClusterReadinessEnabled field in status to determine the cluster readiness status. This is used for PDB reconcile
abhishekdwivedi3060
requested changes
May 7, 2024
Determine enabled security by comparing the config hash of the configMap and the pod.
Co-authored-by: Abhisek Dwivedi <[email protected]>
abhishekdwivedi3060
requested changes
May 14, 2024
tanmayja
commented
May 15, 2024
controllers/rack.go
Outdated
|
|
||
| requiredConfHash := confMap.Data[aerospikeConfHashFileName] | ||
|
|
||
| securityEnabledPods := make([]corev1.Pod, 0, len(pods)) |
There was a problem hiding this comment.
Can we rename this variable, as this function looks generic whether config is updated or not. Func does not check specific about security.
sud82
requested changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.