Added a paused flag to pause the reconciliation of the AerospikeCluster #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanmayja
reviewed
Jul 30, 2024
There was a problem hiding this comment.
- Add this paused flag in helm-charts cluster template.
- Current test is setting the pause flag before starting an upgrade operation, can we add a test case where a running upgrade/rolling restart operation is paused. Mainly to validate the pause logic inside reconcileRack.
helm-charts/aerospike-cluster/templates/aerospike-cluster-cr.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Abhisek Dwivedi <[email protected]>
abhishekdwivedi3060
approved these changes
Aug 14, 2024
tanmayja
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…er resource