Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade controller runtime package #330

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JessicaGreben
Copy link

@JessicaGreben JessicaGreben commented Dec 20, 2024

The cloud team would like to upgrade the version of the controller-runtime package to sigs.k8s.io/controller-runtime v0.19.2 because we are encountering this error when we try to build our code with ako in this PR:

# github.com/aerospike/aerospike-kubernetes-operator/api/v1
../../../../pkg/mod/github.com/aerospike/[email protected]/api/v1/aerospikecluster_webhook.go:38:57: cannot use admission.NewDecoder(mgr.GetScheme()) (value of type admission.Decoder) as *admission.Decoder value in struct literal: admission.Decoder does not implement *admission.Decoder (type *admission.Decoder is pointer to interface, not interface)

We tried to downgrade sigs.k8s.io/controller-runtime v0.17.3 on our side, but it resulted in errors from other packages we are using (for example github.com/external-secrets/external-secrets) that also require a higher version.

Some of the breaking changes in sigs.k8s.io/controller-runtime going from 0.17.3 to 0.19.2 are:

  1. admission.Decoder is now an interface instead of a struct (see PR)
  2. The options.AddFrom method is deleted (ref: docs). This change is causing the CI for this PR to fail since the AddFrom method is used here: https://github.com/aerospike/aerospike-kubernetes-operator/blob/master/cmd/main.go#L79. It seems like a big undertaking to replace that. I'm not sure whats the best path forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant