Upgrade controller runtime package #330
Open
+73
−68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cloud team would like to upgrade the version of the controller-runtime package to
sigs.k8s.io/controller-runtime v0.19.2
because we are encountering this error when we try to build our code with ako in this PR:We tried to downgrade
sigs.k8s.io/controller-runtime v0.17.3
on our side, but it resulted in errors from other packages we are using (for examplegithub.com/external-secrets/external-secrets
) that also require a higher version.Some of the breaking changes in
sigs.k8s.io/controller-runtime
going from0.17.3
to0.19.2
are:admission.Decoder
is now an interface instead of a struct (see PR)options.AddFrom
method is deleted (ref: docs). This change is causing the CI for this PR to fail since theAddFrom
method is used here: https://github.com/aerospike/aerospike-kubernetes-operator/blob/master/cmd/main.go#L79. It seems like a big undertaking to replace that. I'm not sure whats the best path forward.