Skip to content

Commit

Permalink
Adding comment
Browse files Browse the repository at this point in the history
  • Loading branch information
tanmayja committed Dec 18, 2024
1 parent 6d1be96 commit d5f34bf
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions asconfig/conffilewriter.go
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,12 @@ func writeField(buf *bytes.Buffer, key, value string, indent int) {
return
case isEmptyField(key, value):
return
// Skipping the writing of benchmark configurations when their corresponding value is false.
// In server versions without the fix for AER-6767 (https://aerospike.atlassian.net/browse/AER-6767),
// the presence of these fields implied that the corresponding benchmark was enabled,
// even if the value was explicitly set to false.
// To prevent such configurations from being misinterpreted as enabled,
// benchmark configurations with a value of false are now omitted entirely.
case isSpecialBoolField(key):
if strings.EqualFold(value, "false") {
return
Expand Down

0 comments on commit d5f34bf

Please sign in to comment.