Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OM-211 - user-metrics not coming #131

Merged
merged 2 commits into from
Dec 16, 2024
Merged

OM-211 - user-metrics not coming #131

merged 2 commits into from
Dec 16, 2024

Conversation

mphanias
Copy link
Contributor

fixed bug - when auth-mode is configured as PKI, user-metrics are not sent. fixed bug - xdr-metric is validated against user-allow list updated test-case metadata

fixed bug - when auth-mode is configured as PKI, user-metrics are not sent.
fixed bug - xdr-metric is validated against user-allow list
updated test-case metadata
@mphanias mphanias requested a review from sunilvirus December 10, 2024 21:11
Copy link
Member

@sunilvirus sunilvirus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good.
Make sure you delete the Mac entry into the .gitignore

.gitignore Outdated
@@ -1,2 +1,3 @@
aerospike-prometheus-exporter

.DS_Store
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is Mac entry. This change should be removed.

removed .DS_Store entry from .gitignore
@sunilvirus sunilvirus merged commit 053e6c1 into dev Dec 16, 2024
1 check passed
@sunilvirus sunilvirus deleted the OM-211 branch December 16, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants