VEC-323 asd avs on gke tls rbac #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwelch-spike
reviewed
Sep 5, 2024
| @@ -0,0 +1,49 @@ | |||
| import argparse | |||
There was a problem hiding this comment.
Should this file be committed? It seems unnecessary.
hev
approved these changes
Sep 16, 2024
| export ZONE="us-central1-c" | ||
| export FEATURES_CONF="$WORKSPACE/features.conf" | ||
| export BUILD_DIR="$WORKSPACE/generated" | ||
| export RUN_INSECURE=1 |
There was a problem hiding this comment.
This flag name seems opposite of what I'd expect. I think it should be true if you are opting to turn off security, but currently false turns it off security. I like the idea of doing a weird negative opt in here this just doesn't seem right.
There was a problem hiding this comment.
I am actually not sure which does which, as I get the cert and password prompt for both values of the flag.
|
replaced with #60 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will set up a TLS-enabled cluster with the admin:admin
Currently since the helm chart is not published there is a command line argument to point to a helm chart directory.
./full-create-and-install.sh --chart-location /home/joem/src/helm-charts/aerospike-vector-search/