Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VEC-410] Update python client used in example applications #65

Merged
merged 4 commits into from
Oct 30, 2024

Conversation

rahul-aerospike
Copy link
Contributor

  • Updated client version to 3.0.0 everywhere
  • Updated AVS version to 0.11.1 everywhere
  • Minor update in documentation
  • Updated sentence-transformers to 3.2.1 ( was getting cannot import name 'cached_download' from 'huggingface_hub')

@arrowplum
Copy link
Contributor

Would you merge main? I think there are changes in here from a branch that recently got merged.

@rahul-aerospike
Copy link
Contributor Author

Would you merge main? I think there are changes in here from a branch that recently got merged.

Resolved the merge conflict. Did you mean resolving merge conflict or something else.

Copy link
Contributor

@arrowplum arrowplum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question regarding dependencies but lgtm. I think we will have to merge this before #63

@@ -12,7 +12,7 @@ waitress

# Quote processing
numpy==1.26.4 # fix issues in dependencies after 2.0.0 release
sentence-transformers==2.2.2
sentence-transformers==3.2.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any idea why we were using https://github.com/UKPLab/sentence-transformers/releases/tag/v2.2.2 before? This doesn't break anything we are using?

Copy link
Contributor Author

@rahul-aerospike rahul-aerospike Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked into git history.
When this work was done (10/11/2023); the 2.2.2 was the latest version of sentence-transformers package. My guess is, this is the reason that specific version(2.2.2) was used then.

link to pypi release history: https://pypi.org/project/sentence-transformers/#history

On the breaking aspects:
I think we will have to go to every application and ensure the versions are updated everywhere. While debugging came across very recent issues

@arrowplum
Copy link
Contributor

Would you merge main? I think there are changes in here from a branch that recently got merged.

Resolved the merge conflict. Did you mean resolving merge conflict or something else.

I had seen changes from the other branch. Fixed with merge.

Copy link
Contributor

@dwelch-spike dwelch-spike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hev hev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested prism only, and reviewed manually. Approved.

@rahul-aerospike rahul-aerospike changed the title Avs3.0.0 client updates AVS 3.0.0 python client updates Oct 30, 2024
@rahul-aerospike rahul-aerospike merged commit 7d31c2b into main Oct 30, 2024
1 check passed
@rahul-aerospike rahul-aerospike deleted the avs3.0.0-client-updates branch October 30, 2024 19:32
@rahul-aerospike rahul-aerospike changed the title AVS 3.0.0 python client updates [VEC-410] Update python client used in example applications Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants